feat: add the network origin HTTP to the register-signatures endpoint of the API

Author: Clément TURMEL

mithril-aggregator/src/http_server/routes/signatures_routes.rs

@@ -40,6 +40,8 @@ mod handlers {
         unwrap_to_internal_server_error, MetricsService, SingleSignatureAuthenticator,
     };
 
+    const METRICS_HTTP_ORIGIN: &str = "HTTP";
+
     /// Register Signatures
     pub async fn register_signatures(
         origin_tag: Option<String>,
@@ -53,7 +55,7 @@ mod handlers {
 
         metrics_service
             .get_signature_registration_total_received_since_startup()
-            .increment(&[origin_tag.as_deref().unwrap_or_default()]);
+            .increment(&[METRICS_HTTP_ORIGIN]);
 
         let signed_entity_type = message.signed_entity_type.clone();
         let signed_message = message.signed_message.clone();
@@ -158,16 +160,14 @@ mod tests {
         let initial_counter_value = dependency_manager
             .metrics_service
             .get_signature_registration_total_received_since_startup()
-            .get(&["TEST"]);
+            .get(&["HTTP"]);
 
         request()
             .method(method)
             .path(path)
             .json(&RegisterSignatureMessage::dummy())
-            .header(MITHRIL_ORIGIN_TAG_HEADER, "TEST")
-            .reply(&setup_router(RouterState::new_with_origin_tag_white_list(
+            .reply(&setup_router(RouterState::new_with_dummy_config(
                 dependency_manager.clone(),
-                &["TEST"],
             )))
             .await;
 
@@ -176,7 +176,7 @@ mod tests {
             dependency_manager
                 .metrics_service
                 .get_signature_registration_total_received_since_startup()
-                .get(&["TEST"])
+                .get(&["HTTP"])
         );
     }
 

mithril-aggregator/src/metrics/service.rs

@@ -5,85 +5,88 @@ use mithril_metric::{build_metrics_service, MetricCounterWithLabels, MetricsServ
 use mithril_metric::metric::{MetricCollector, MetricCounter};
 use prometheus::proto::{LabelPair, MetricFamily};
 
-static ORIGIN_TAG_LABEL: &str = "origin_tag";
+// Those are three differents dimensions, they use the same value to simplify usage in Grafana
+static CLIENT_ORIGIN_TAG_LABEL: &str = "origin_tag";
+static SIGNER_REGISTRATION_ORIGIN_TAG_LABEL: &str = "origin_tag";
+static SIGNER_SIGNATURE_ORIGIN_TAG_LABEL: &str = "origin_tag";
 
 build_metrics_service!(
     MetricsService,
 
     certificate_detail_total_served_since_startup:MetricCounterWithLabels(
         "certificate_detail_total_served_since_startup",
         "Number of certificate details served since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[CLIENT_ORIGIN_TAG_LABEL]
     ),
     artifact_detail_cardano_immutable_files_full_total_served_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_artifact_detail_cardano_db_total_served_since_startup",
         "Number of Cardano immutable files full artifact details served since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[CLIENT_ORIGIN_TAG_LABEL]
     ),
     cardano_immutable_files_full_total_restoration_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_cardano_db_total_restoration_since_startup",
         "Number of Cardano immutable files full restorations since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[CLIENT_ORIGIN_TAG_LABEL]
     ),
     cardano_database_immutable_files_restored_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_cardano_db_immutable_files_restored_since_startup",
         "Number of Cardano immutable files restored since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[CLIENT_ORIGIN_TAG_LABEL]
     ),
     cardano_database_ancillary_files_restored_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_cardano_db_ancillary_files_restored_since_startup",
         "Number of Cardano ancillary files restored since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[CLIENT_ORIGIN_TAG_LABEL]
     ),
     cardano_database_complete_restoration_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_cardano_db_complete_restoration_since_startup",
         "Number of complete Cardano database restoration since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[CLIENT_ORIGIN_TAG_LABEL]
     ),
     cardano_database_partial_restoration_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_cardano_db_partial_restoration_since_startup",
         "Number of partial Cardano database restoration since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[CLIENT_ORIGIN_TAG_LABEL]
     ),
     artifact_detail_cardano_database_total_served_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_artifact_detail_cardano_database_total_served_since_startup",
         "Number of Cardano database artifact details served since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[CLIENT_ORIGIN_TAG_LABEL]
     ),
     artifact_detail_mithril_stake_distribution_total_served_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_artifact_detail_mithril_stake_distribution_total_served_since_startup",
         "Number of Mithril stake distribution artifact details served since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[CLIENT_ORIGIN_TAG_LABEL]
     ),
     artifact_detail_cardano_stake_distribution_total_served_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_artifact_detail_cardano_stake_distribution_total_served_since_startup",
         "Number of Cardano stake distribution artifact details served since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[CLIENT_ORIGIN_TAG_LABEL]
     ),
     artifact_detail_cardano_transaction_total_served_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_artifact_detail_cardano_transaction_total_served_since_startup",
         "Number of Cardano transaction artifact details served since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[CLIENT_ORIGIN_TAG_LABEL]
     ),
     proof_cardano_transaction_total_proofs_served_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_proof_cardano_transaction_total_proofs_served_since_startup",
         "Number of Cardano transaction proofs served since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[CLIENT_ORIGIN_TAG_LABEL]
     ),
     proof_cardano_transaction_total_transactions_served_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_proof_cardano_transaction_total_transactions_served_since_startup",
         "Number of Cardano transaction hashes requested for proof since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[CLIENT_ORIGIN_TAG_LABEL]
     ),
     signer_registration_total_received_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_signer_registration_total_received_since_startup",
         "Number of signer registrations received since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[SIGNER_REGISTRATION_ORIGIN_TAG_LABEL]
     ),
     signature_registration_total_received_since_startup:MetricCounterWithLabels(
         "mithril_aggregator_signature_registration_total_received_since_startup",
         "Number of signature registrations received since startup on a Mithril aggregator node",
-        &[ORIGIN_TAG_LABEL]
+        &[SIGNER_SIGNATURE_ORIGIN_TAG_LABEL]
     ),
     certificate_total_produced_since_startup:MetricCounter(
         "mithril_aggregator_certificate_total_produced_since_startup",