feat(client-cli): stable 'tools utxo-hd' command

Author: jpraynaud

mithril-client-cli/src/commands/cardano_db/shared_steps.rs

@@ -172,7 +172,7 @@ pub fn log_download_information(
 
     let snapshot_converter_cmd = |flavor| {
         format!(
-            "mithril-client --unstable tools utxo-hd snapshot-converter --db-directory {} --cardano-node-version {} --utxo-hd-flavor {} --commit",
+            "mithril-client tools utxo-hd snapshot-converter --db-directory {} --cardano-node-version {} --utxo-hd-flavor {} --commit",
             db_dir.display(),
             cardano_node_version,
             flavor,

mithril-client-cli/src/commands/tools/mod.rs

@@ -13,7 +13,7 @@ use mithril_client::MithrilResult;
 
 /// Tools commands
 #[derive(Subcommand, Debug, Clone)]
-#[command(about = "[unstable] Tools commands")]
+#[command(about = "Tools commands")]
 pub enum ToolsCommands {
     /// UTxO-HD related commands
     #[clap(subcommand, name = "utxo-hd")]

mithril-client-cli/src/main.rs

@@ -250,10 +250,7 @@ impl ArtifactCommands {
             Self::GenerateDoc(cmd) => {
                 cmd.execute(&mut Args::command()).map_err(|message| anyhow!(message))
             }
-            Self::Tools(cmd) => {
-                context.require_unstable("tools", Some("utxo-hd snapshot-converter"))?;
-                cmd.execute().await
-            }
+            Self::Tools(cmd) => cmd.execute().await,
         }
     }
 }
@@ -281,36 +278,6 @@ async fn main() -> MithrilResult<()> {
 mod tests {
     use super::*;
 
-    #[tokio::test]
-    async fn fail_if_tools_command_is_used_without_unstable_flag() {
-        let args = Args::try_parse_from([
-            "mithril-client",
-            "tools",
-            "utxo-hd",
-            "snapshot-converter",
-            "--db-directory",
-            "whatever",
-            "--cardano-network",
-            "preview",
-            "--cardano-node-version",
-            "1.2.3",
-            "--utxo-hd-flavor",
-            "Legacy",
-        ])
-        .unwrap();
-
-        let error = args
-            .execute(Logger::root(slog::Discard, slog::o!()))
-            .await
-            .expect_err("Should fail if unstable flag missing");
-
-        assert!(
-            error
-                .to_string()
-                .contains("subcommand is only accepted using the --unstable flag.")
-        );
-    }
-
     #[tokio::test]
     async fn verify_subcommand_should_fail_with_cardano_db_v1() {
         let args = Args::try_parse_from([