feat(cli): prevent snapshot converter execution and hide post-download commands on Linux ARM

Author: dlachaume

mithril-client-cli/src/commands/cardano_db/shared_steps.rs

@@ -134,6 +134,10 @@ pub fn log_download_information(
     json_output: bool,
     include_ancillary: bool,
 ) -> MithrilResult<()> {
+    fn is_linux_arm() -> bool {
+        cfg!(target_os = "linux") && cfg!(target_arch = "aarch64")
+    }
+
     let canonical_filepath = &db_dir
         .canonicalize()
         .with_context(|| format!("Could not get canonical filepath of '{}'", db_dir.display()))?;
@@ -155,53 +159,56 @@ pub fn log_download_information(
     };
 
     if json_output {
-        let json = if include_ancillary {
-            serde_json::json!({
-                "timestamp": Utc::now().to_rfc3339(),
-                "db_directory": canonical_filepath,
-                "run_docker_cmd": docker_cmd,
-                "snapshot_converter_cmd_to_lmdb": snapshot_converter_cmd("LMDB"),
-                "snapshot_converter_cmd_to_legacy": snapshot_converter_cmd("Legacy")
-            })
-        } else {
-            serde_json::json!({
-                "timestamp": Utc::now().to_rfc3339(),
-                "db_directory": canonical_filepath,
-                "run_docker_cmd": docker_cmd
-            })
-        };
+        let mut json = serde_json::json!({
+            "timestamp": Utc::now().to_rfc3339(),
+            "db_directory": canonical_filepath,
+        });
+
+        if !is_linux_arm() {
+            json["run_docker_cmd"] = serde_json::Value::String(docker_cmd);
+
+            if include_ancillary {
+                json["snapshot_converter_cmd_to_lmdb"] =
+                    serde_json::Value::String(snapshot_converter_cmd("LMDB"));
+                json["snapshot_converter_cmd_to_legacy"] =
+                    serde_json::Value::String(snapshot_converter_cmd("Legacy"));
+            }
+        }
 
         println!("{json}");
     } else {
         println!(
             r###"Cardano database snapshot '{}' archives have been successfully unpacked. Immutable files have been successfully verified with Mithril.
 
     Files in the directory '{}' can be used to run a Cardano node with version >= {cardano_node_version}.
-
-    If you are using Cardano Docker image, you can restore a Cardano Node with:
-
-    {}
-
     "###,
             snapshot_hash,
-            db_dir.display(),
-            docker_cmd
+            db_dir.display()
         );
 
-        if include_ancillary {
+        if !is_linux_arm() {
             println!(
-                r###"Upgrade and replace the restored ledger state snapshot to 'LMDB' flavor by running the command:
+                r###"If you are using the Cardano Docker image, you can restore a Cardano node with:
+
+    {docker_cmd}
+
+    "###
+            );
+
+            if include_ancillary {
+                println!(
+                    r###"Upgrade and replace the restored ledger state snapshot to 'LMDB' flavor by running the command:
 
     {}
 
     Or to 'Legacy' flavor by running the command:
 
     {}
-
     "###,
-                snapshot_converter_cmd("LMDB"),
-                snapshot_converter_cmd("Legacy"),
-            );
+                    snapshot_converter_cmd("LMDB"),
+                    snapshot_converter_cmd("Legacy"),
+                );
+            }
         }
     }
 

mithril-client-cli/src/commands/tools/mod.rs

@@ -7,6 +7,7 @@ mod snapshot_converter;
 
 pub use snapshot_converter::*;
 
+use anyhow::anyhow;
 use clap::Subcommand;
 use mithril_client::MithrilResult;
 
@@ -40,7 +41,14 @@ impl UTxOHDCommands {
     /// Execute UTxO-HD command
     pub async fn execute(&self) -> MithrilResult<()> {
         match self {
-            Self::SnapshotConverter(cmd) => cmd.execute().await,
+            Self::SnapshotConverter(cmd) => {
+                if cfg!(target_os = "linux") && cfg!(target_arch = "aarch64") {
+                    return Err(anyhow!(
+                        "'snapshot-converter' command is not supported on Linux ARM"
+                    ));
+                }
+                cmd.execute().await
+            }
         }
     }
 }