fix clippy (#3938)

Author: Mr-Leshiy

jormungandr-lib/src/interfaces/block0_configuration/kes_update_speed.rs

@@ -35,7 +35,8 @@ impl KesUpdateSpeed {
     /// returns `None` if the value is not within the boundaries of
     /// `KesUpdateSpeed::MINIMUM` and `KesUpdateSpeed::MAXIMUM`.
     pub fn new(v: u32) -> Option<Self> {
-        if v < MINIMUM_KES_SPEED_UPDATE_IN_SECONDS || MAXIMUM_KES_SPEED_UPDATE_IN_SECONDS < v {
+        if !(MINIMUM_KES_SPEED_UPDATE_IN_SECONDS..=MAXIMUM_KES_SPEED_UPDATE_IN_SECONDS).contains(&v)
+        {
             None
         } else {
             Some(KesUpdateSpeed(v))

jormungandr-lib/src/interfaces/block0_configuration/number_of_slots_per_epoch.rs

@@ -34,7 +34,7 @@ impl NumberOfSlotsPerEpoch {
     /// returns `None` if the value is not within the boundaries of
     /// `NumberOfSlotsPerEpoch::MINIMUM` and `NumberOfSlotsPerEpoch::MAXIMUM`.
     pub fn new(v: u32) -> Option<Self> {
-        if v < MINIMUM_NUMBER_OF_SLOTS_PER_EPOCH || MAXIMUM_NUMBER_OF_SLOTS_PER_EPOCH < v {
+        if !(MINIMUM_NUMBER_OF_SLOTS_PER_EPOCH..=MAXIMUM_NUMBER_OF_SLOTS_PER_EPOCH).contains(&v) {
             None
         } else {
             Some(Self(v))

jormungandr-lib/src/interfaces/block0_configuration/slots_duration.rs

@@ -34,7 +34,7 @@ impl SlotDuration {
     /// `SlotDuration::MINIMUM` and `SlotDuration::MAXIMUM`.
     #[allow(clippy::absurd_extreme_comparisons)]
     pub fn new(v: u8) -> Option<Self> {
-        if v < MINIMUM_SLOT_DURATION || MAXIMUM_SLOT_DURATION < v {
+        if !(MINIMUM_SLOT_DURATION..=MAXIMUM_SLOT_DURATION).contains(&v) {
             None
         } else {
             Some(Self(v))

jormungandr/src/utils/task.rs

@@ -291,10 +291,9 @@ impl TokioServiceInfo {
         tracing::trace!("spawning {}", name);
         self.handle.spawn(
             async move {
-                match tokio::time::timeout(timeout, future).await {
-                    Err(_) => tracing::error!("task {} timed out", name),
-                    Ok(()) => {}
-                };
+                if tokio::time::timeout(timeout, future).await.is_err() {
+                    tracing::error!("task {} timed out", name);
+                }
             }
             .instrument(span!(parent: &self.span, Level::TRACE, "task", kind = name)),
         );

testing/jormungandr-integration-tests/src/jormungandr/legacy.rs

@@ -19,7 +19,7 @@ pub fn test_legacy_node_all_fragments() {
     let temp_dir = TempDir::new().unwrap();
     let jcli: JCli = Default::default();
 
-    let legacy_release = download_last_n_releases(1).iter().cloned().next().unwrap();
+    let legacy_release = download_last_n_releases(1).get(0).cloned().unwrap();
     let jormungandr = get_jormungandr_bin(&legacy_release, &temp_dir);
 
     let mut first_stake_pool_owner = thor::Wallet::default();

testing/jormungandr-integration-tests/src/non_functional/bootstrap.rs

@@ -81,7 +81,7 @@ pub fn legacy_bootstrap_from_1_gb_storage() {
         .with_storage(&child)
         .build(&temp_dir);
 
-    let legacy_release = download_last_n_releases(1).iter().cloned().next().unwrap();
+    let legacy_release = download_last_n_releases(1).get(0).cloned().unwrap();
     let jormungandr_app = get_jormungandr_bin(&legacy_release, &temp_dir);
 
     let jormungandr = Starter::new()