Npg 3331 explorer testing infra (#4084)

* explorer tests

* reformat test file

* reformat block.graphql

* ci fixes

* ci fixes

* address clippy fixes

* pr review refactor + ci fixes

* add default for test config

* cargo fmt fix

* allow(clippy::derive_partial_eq_without_eq)

* clippy suggestions (CI fix)

* clippy suggestions (CI fix)

Author: cong-or

Cargo.lock

@@ -40,6 +40,9 @@ lazy_static = "1.4"
 http-zipkin = "0.3.0"
 
 jormungandr-lib = {path = "../jormungandr-lib"}
+jormungandr-automation = { path = "../testing/jormungandr-automation" }
+jormungandr-integration-tests = { path = "../testing/jormungandr-integration-tests" }
+thor = { path = "../testing/thor" }
 
 cardano-legacy-address = {git = "https://github.com/input-output-hk/chain-libs.git", branch = "master"}
 chain-addr = {git = "https://github.com/input-output-hk/chain-libs.git", branch = "master"}

explorer/Cargo.toml

@@ -505,7 +505,7 @@ impl Block {
             Ok(Arc::clone(block))
         } else {
             let block = db.get_block(&self.hash).await.ok_or_else(|| {
-                ApiError::InternalError("Couldn't find block's contents in explorer".to_owned())
+                ApiError::InternalError("Couldn't find block in the explorer".to_owned())
             })?;
 
             *contents = Some(Arc::clone(&block));
@@ -518,7 +518,7 @@ impl Block {
             db.get_block_with_branches(&self.hash)
                 .await
                 .ok_or_else(|| {
-                    ApiError::InternalError("Couldn't find block's contents in explorer".to_owned())
+                    ApiError::InternalError("Couldn't find block in the explorer".to_owned())
                 })?;
 
         let mut contents = self.contents.lock().await;

explorer/src/api/graphql/mod.rs

@@ -113,13 +113,13 @@ pub fn filter(
                 parent_span_id = Empty,
             );
             if let Some(remote_addr) = info.remote_addr() {
-                span.record("remote_addr", &remote_addr.to_string().as_str());
+                span.record("remote_addr", remote_addr.to_string().as_str());
             }
             if let Some(trace_context) = get_trace_context(info.request_headers()) {
-                span.record("trace_id", &trace_context.trace_id().to_string().as_str());
-                span.record("span_id", &trace_context.span_id().to_string().as_str());
+                span.record("trace_id", trace_context.trace_id().to_string().as_str());
+                span.record("span_id", trace_context.span_id().to_string().as_str());
                 if let Some(parent_span_id) = trace_context.parent_id() {
-                    span.record("parent_span_id", &parent_span_id.to_string().as_str());
+                    span.record("parent_span_id", parent_span_id.to_string().as_str());
                 }
             }
             span

explorer/src/api/mod.rs

@@ -123,7 +123,7 @@ impl LogSettings {
                     .create(true)
                     .write(true)
                     .append(true)
-                    .open(&path)
+                    .open(path)
                     .map_err(|cause| Error::File {
                         path: path.clone(),
                         cause,

explorer/src/logging.rs

@@ -4,6 +4,9 @@ mod indexer;
 mod logging;
 mod settings;
 
+#[cfg(test)]
+mod tests;
+
 use crate::indexer::Indexer;
 use anyhow::Context;
 use chain_core::{packer::Codec, property::Deserialize};

explorer/src/main.rs

@@ -252,7 +252,7 @@ mod filter_level_opt_serde {
         Option::<String>::deserialize(deserializer)?
             .map(|variant| {
                 variant.parse().map_err(|_| {
-                    D::Error::unknown_variant(&variant, &**LOG_FILTER_LEVEL_POSSIBLE_VALUES)
+                    D::Error::unknown_variant(&variant, &LOG_FILTER_LEVEL_POSSIBLE_VALUES)
                 })
             })
             .transpose()

explorer/src/settings.rs

@@ -0,0 +1,78 @@
+use chain_core::property::FromStr;
+use jormungandr_automation::jormungandr::{
+    explorer::configuration::ExplorerParams, ConfigurationBuilder, Explorer, JormungandrProcess,
+};
+use jormungandr_integration_tests::startup;
+use jormungandr_lib::{crypto::hash::Hash, interfaces::ActiveSlotCoefficient};
+
+pub struct ExplorerTestConfig {
+    query_complexity_limit: u64,
+}
+
+impl Default for ExplorerTestConfig {
+    fn default() -> Self {
+        ExplorerTestConfig {
+            query_complexity_limit: 150,
+        }
+    }
+}
+
+pub fn explorer_test_context(
+    test_config: ExplorerTestConfig,
+) -> (
+    jormungandr_automation::jormungandr::ExplorerProcess,
+    JormungandrProcess,
+) {
+    let faucet = thor::Wallet::default();
+
+    let mut config = ConfigurationBuilder::new();
+    config.with_consensus_genesis_praos_active_slot_coeff(ActiveSlotCoefficient::MAXIMUM);
+
+    let (jormungandr, _initial_stake_pools) =
+        startup::start_stake_pool(&[faucet], &[], &mut config).unwrap();
+
+    let params = ExplorerParams::new(test_config.query_complexity_limit, None, None);
+
+    (jormungandr.explorer(params), jormungandr)
+}
+
+pub fn get_invalid_block(explorer: &Explorer) {
+    let hash =
+        Hash::from_str("000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f").unwrap();
+
+    let predicted_errors = vec![
+        "internal error (this shouldn't happen) Couldn't find block in the explorer".to_string(),
+    ];
+
+    let actual_errors: Vec<String> = explorer
+        .block(hash)
+        .unwrap()
+        .errors
+        .unwrap()
+        .iter()
+        .map(|error| error.message.to_string())
+        .collect();
+
+    assert_eq!(predicted_errors, actual_errors);
+}
+
+pub fn get_valid_block(explorer: &Explorer, genesis_block: Hash) {
+    let block_id = explorer
+        .block(genesis_block)
+        .unwrap()
+        .data
+        .unwrap()
+        .block
+        .id;
+    assert_eq!(block_id, genesis_block.to_string());
+}
+
+#[test]
+pub fn explorer_tests() {
+    let config = ExplorerTestConfig::default();
+
+    let (explorer, jormungandr) = explorer_test_context(config);
+
+    get_invalid_block(explorer.client());
+    get_valid_block(explorer.client(), jormungandr.genesis_block_hash());
+}

explorer/src/tests.rs

@@ -118,7 +118,7 @@ fn address_info(address: &AddressReadable) -> Result<(), Error> {
             println!("public key: {}", pubk.to_bech32_str());
             println!("group key:  {}", groupk.to_bech32_str());
         }
-        Kind::Script(id) => println!("script identifier: {}", hex::encode(&id)),
+        Kind::Script(id) => println!("script identifier: {}", hex::encode(id)),
     }
     Ok(())
 }

jcli/src/jcli_lib/address.rs

@@ -50,7 +50,7 @@ impl Serialize for CommitteeIdDef {
         S: Serializer,
     {
         if serializer.is_human_readable() {
-            let hex = hex::encode(&self.0);
+            let hex = hex::encode(self.0);
             serializer.serialize_str(&hex)
         } else {
             serializer.serialize_bytes(&self.0)