Skip to content

Commit f8c97c5

Browse files
[DDW-917] Fix quality checks (#2828)
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
1 parent 37495fa commit f8c97c5

File tree

4 files changed

+22
-6
lines changed

4 files changed

+22
-6
lines changed

.github/pull_request_template.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ Open a thread on #daedalus-qa on Slack, mention `@daedalusqa` and `@daedalusteam
4141
- [ ] PR assigned to the PR author(s)
4242
- [ ] `input-output-hk/daedalus-dev` and `input-output-hk/daedalus-qa` assigned as PR reviewers
4343
- [ ] If there are UI changes, Alexander Rukin assigned as an additional reviewer
44+
- [ ] All visual regression testing has been reviewed (Go to Github Actions tab -> Select Chromatic workflow -> Run on your working branch)
4445
- [ ] PR has appropriate labels (`release-vNext`, `feature`/`bug`/`chore`, `WIP`)
4546
- [ ] PR link is added to a Jira ticket, ticket moved to In Review
4647
- [ ] PR is updated to the most recent version of the target branch (and there are no conflicts)

.github/workflows/chromatic.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
name: 'Chromatic'
2-
on: push
2+
on:
3+
workflow_dispatch:
4+
push:
5+
branches:
6+
- develop
7+
38
jobs:
49
chromatic-deployment:
510
runs-on: ubuntu-latest

.github/workflows/linter.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
name: Run Linter for Pull Requests
2+
on:
3+
push:
4+
jobs:
5+
tests:
6+
runs-on: ubuntu-latest
7+
steps:
8+
- name: Checkout Repo
9+
uses: actions/checkout@v2
10+
- name: Setup Node.js
11+
uses: actions/setup-node@v2
12+
with:
13+
node-version: "14"
14+
- run: yarn install --frozen-lockfile
15+
- run: yarn prettier:check && yarn lint && yarn stylelint

bors.toml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
status = [
22
# Buildkite: osx/linux installers
33
"buildkite/daedalus",
4-
5-
# Hydra: we just care about tests attribute set
6-
"ci/hydra:Cardano:daedalus:tests.runFlow",
7-
"ci/hydra:Cardano:daedalus:tests.runLint",
8-
"ci/hydra:Cardano:daedalus:tests.runShellcheck"
94
]
105
timeout_sec = 7200
116
required_approvals = 1

0 commit comments

Comments
 (0)