[DDW-157] Update Daedalus installer file name (#1971)

* Adds modified build product names per ddw-157

* [DDW-157] Adds a CHANGELOG

* Fix Linux/Win backend reported api version

Co-authored-by: John Lotoski <john.lotoski@iohk.io>

Author: nikolaglumac

CHANGELOG.md

@@ -11,6 +11,7 @@ Changelog
 
 ### Chores
 
+- Updated Daedalus installer file names to contain only Daedalus version, cluster name and build number ([PR 1971](https://github.com/input-output-hk/daedalus/pull/1971))
 - Restore the paragraph about "Automatic wallet migration" on the Daedalus Flight "Splash" screen ([PR 1967](https://github.com/input-output-hk/daedalus/pull/1967))
 - Updated `Electron` and it's related dependencies ([PR 1887](https://github.com/input-output-hk/daedalus/pull/1887))
 

default.nix

@@ -263,14 +263,14 @@ let
       makensis daedalus.nsi -V4
 
       echo '~~~   Copying to $out'
-      cp daedalus-*-*-wallet-*-windows*.exe $out/
+      cp daedalus-*-*.exe $out/
       cp *.yaml $out/cfg-files/
       echo file installer $out/*.exe > $out/nix-support/hydra-build-products
     '';
     signed-windows-installer = let
       backend_version = self.daedalus-bridge.wallet-version;
       frontend_version = (builtins.fromJSON (builtins.readFile ./package.json)).version;
-      fullName = "daedalus-${frontend_version}-cardano-wallet-${backend_version}-${cluster}-windows${buildNumSuffix}.exe"; # must match to packageFileName in make-installer
+      fullName = "daedalus-${frontend_version}-${cluster}${buildNumSuffix}.exe"; # must match to packageFileName in make-installer
     in pkgs.runCommand "signed-windows-installer-${cluster}" {} ''
       mkdir $out
       cp -v ${self.signFile "${self.unsigned-windows-installer}/${fullName}"} $out/${fullName}
@@ -287,7 +287,7 @@ let
     rawapp = self.callPackage ./yarn2nix.nix {
       inherit buildNum;
       api = "ada";
-      apiVersion = self.cardano-sl.daedalus-bridge.version;
+      apiVersion = self.daedalus-bridge.wallet-version;
       inherit (self.launcherConfigs.installerConfig) spacedName;
       inherit (self.launcherConfigs) launcherConfig;
       inherit cluster;
@@ -401,7 +401,7 @@ let
       version = (builtins.fromJSON (builtins.readFile ./package.json)).version;
       backend = "cardano-wallet-${nodeImplementation}";
       suffix = if buildNum == null then "" else "-${toString buildNum}";
-      fn = "daedalus-${version}-${backend}-${self.linuxClusterBinName}-${target}${suffix}.bin";
+      fn = "daedalus-${version}-${self.linuxClusterBinName}${suffix}.bin";
     in pkgs.runCommand fn {} ''
       mkdir -p $out
       cp ${self.newBundle} $out/${fn}

installers/common/Types.hs

@@ -115,18 +115,18 @@ clusterNetwork Staging = "staging"
 clusterNetwork Testnet = "testnet"
 
 packageFileName :: OS -> Cluster -> Version -> Backend -> Text -> Maybe BuildJob -> FilePath
-packageFileName os cluster ver backend backendVer build = fromText name <.> ext
+packageFileName _os cluster ver backend _backendVer build = fromText name <.> ext
   where
     name = T.intercalate "-" parts
-    parts = ["daedalus", fromVer ver, backend', backendVer, lshowText cluster, os'] ++ build'
-    backend' = case backend of
+    parts = ["daedalus", fromVer ver, lshowText cluster] ++ build'
+    _backend' = case backend of
                  Cardano _ -> "cardano-wallet"
                  Jormungandr _ -> "jormungandr-wallet"
-    ext = case os of
+    ext = case _os of
             Win64   -> "exe"
             Macos64 -> "pkg"
             Linux64 -> "bin"
-    os' = case os of
+    _os' = case _os of
             Win64   -> "windows"
             Macos64 -> "macos"
             Linux64 -> "linux"

scripts/build-cross-windows.sh

@@ -18,6 +18,6 @@ for cluster in ${CLUSTERS}; do
   echo '~~~ Building '"${cluster}"' installer'
   nix-build default.nix -A windows-installer --arg disabledsigningKeys '{ spc = ./dummy-certs/authenticode.spc; pvk = ./dummy-certs/authenticode.pvk; }' --show-trace  --allow-unsafe-native-code-during-evaluation --argstr cluster "$cluster" --argstr buildNum "$BUILDKITE_BUILD_NUMBER" --argstr target "x86_64-windows"
   if [ -n "${BUILDKITE_JOB_ID:-}" ]; then
-    upload_artifacts_public result/daedalus-*-windows*.exe
+    upload_artifacts_public result/daedalus-*-*.exe
   fi
 done