1- This PR CHANGES.
1+ <!-- -
2+ Briefly describe the change.
3+ -->
4+
5+ This PR ...
26
37## Todos
48
5- - [ ] Todo
9+ <!-- -
10+ Consider creating a TODO list to help others understand the progress of work in a WIP pull request.
11+ -->
612
7- ## Screenshots
13+ - [ ] TODO
814
9- - Screenshot
15+ ## Screenshots
1016
11- ---
17+ <!-- -
18+ Use the GitHub drag&drop feature to upload default-sized Daedalus window screenshots
19+ or animated GIFs of important UI changes in both English and Japanese.
20+ Do not use shadow or any effects. On macOS this can be accomplished the following way:
21+ 1. Use the Command+Shift+4 keyboard shortcut.
22+ 2. Press the Spacebar.
23+ 3. Hold the Option button and click the window you want to capture.
24+ -->
1225
1326## Testing Checklist
1427
28+ <!-- -
29+ Open a thread on #daedalus-qa on Slack, mention `@daedalusqa` and `@daedalusteam`, link the thread below
30+ -->
31+
32+
1533- [ Slack QA thread] ( https://input-output-rnd.slack.com/messages/GGKFXSKC6 )
1634- [ ] Test
1735
@@ -20,24 +38,18 @@ This PR CHANGES.
2038## Review Checklist
2139
2240### Basics
23-
24- - [ ] PR has been assigned and has appropriate labels (` feature ` /` bug ` /` chore ` , ` release-x.x.x ` )
41+ - [ ] PR assigned to the PR author(s)
42+ - [ ] ` input-output-hk/daedalus-dev ` and ` input-output-hk/daedalus-qa ` assigned as PR reviewers
43+ - [ ] If there are UI changes, Alexander Rukin assigned as an additional reviewer
44+ - [ ] PR has appropriate labels (` release-vNext ` , ` feature ` /` bug ` /` chore ` , ` WIP ` )
45+ - [ ] PR link is added to a Jira ticket, ticket moved to In Review
2546- [ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
2647- [ ] PR has a good description that summarizes all changes
27- - [ ] PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
28- - [ ] In English
29- - [ ] In Japanese
48+ - [ ] PR contains screenshots (in case of UI changes)
3049- [ ] CHANGELOG entry has been added to the top of the appropriate section (* Features* , * Fixes* , * Chores* ) and is linked to the correct PR on GitHub
31- - [ ] Automated tests: All acceptance and unit tests are passing (` yarn test ` )
32- - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in * development* build (` yarn dev ` )
33- - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in * production* build (` yarn package ` / CI builds)
34- - [ ] There are no * flow* errors or warnings (` yarn flow:test ` )
35- - [ ] There are no * lint* errors or warnings (` yarn lint ` )
36- - [ ] There are no * prettier* errors or warnings (` yarn prettier:check ` )
3750- [ ] There are no missing translations (running ` yarn manage:translations ` produces no changes)
3851- [ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
3952- [ ] Japanese text changes are proofread and approved (Junko Oda)
40- - [ ] UI changes look good in all themes (Alexander Rukin)
4153- [ ] Storybook works and no stories are broken (` yarn storybook ` )
4254- [ ] In case of dependency changes ` yarn.lock ` file is updated
4355
@@ -55,7 +67,4 @@ This PR CHANGES.
5567- [ ] All existing Daedalus Testing scenarios are still up-to-date
5668
5769### After Review
58- - [ ] Merge the PR
59- - [ ] Delete the source branch
60- - [ ] Move the ticket to ` done ` column on the YouTrack board
6170- [ ] Update Slack QA thread by marking it with a green checkmark
0 commit comments