Skip to content

Commit 7b66896

Browse files
committed
[DDW-773] updated PR template + CHANGELOG
1 parent 45504d9 commit 7b66896

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

.github/pull_request_template.md

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ or animated GIFs of important UI changes in both English and Japanese.
2020
Do not use shadow or any effects. On macOS this can be accomplished the following way:
2121
1. Use the Command+Shift+4 keyboard shortcut.
2222
2. Press the Spacebar.
23-
3. Hold the Option button and click the window you want to capture.
23+
3. Hold the Option button and click the window you want to capture.
2424
-->
2525

2626
## Testing Checklist
@@ -29,7 +29,6 @@ Do not use shadow or any effects. On macOS this can be accomplished the followin
2929
Open a thread on #daedalus-qa on Slack, mention `@daedalusqa` and `@daedalusteam`, link the thread below
3030
-->
3131

32-
3332
- [Slack QA thread](https://input-output-rnd.slack.com/messages/GGKFXSKC6)
3433
- [ ] Test
3534

@@ -38,7 +37,8 @@ Open a thread on #daedalus-qa on Slack, mention `@daedalusqa` and `@daedalusteam
3837
## Review Checklist
3938

4039
### Basics
41-
- [ ] PR assigned to the PR author(s)
40+
41+
- [ ] PR assigned to the PR author(s)
4242
- [ ] `input-output-hk/daedalus-dev` and `input-output-hk/daedalus-qa` assigned as PR reviewers
4343
- [ ] If there are UI changes, Alexander Rukin assigned as an additional reviewer
4444
- [ ] All visual regression testing has been reviewed (Go to Github Actions tab -> Select Chromatic workflow -> Run on your working branch)
@@ -47,25 +47,28 @@ Open a thread on #daedalus-qa on Slack, mention `@daedalusqa` and `@daedalusteam
4747
- [ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
4848
- [ ] PR has a good description that summarizes all changes
4949
- [ ] PR contains screenshots (in case of UI changes)
50-
- [ ] CHANGELOG entry has been added to the top of the appropriate section (*Features*, *Fixes*, *Chores*) and is linked to the correct PR on GitHub
50+
- [ ] CHANGELOG entry has been added to the top of the appropriate section (_Features_, _Fixes_, _Chores_) and is linked to the correct PR on GitHub
5151
- [ ] There are no missing translations (running `yarn manage:translations` produces no changes)
5252
- [ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
5353
- [ ] Japanese text changes are proofread and approved (Junko Oda)
5454
- [ ] Storybook works and no stories are broken (`yarn storybook`)
5555
- [ ] In case of dependency changes `yarn.lock` file is updated
5656

5757
### Code Quality
58+
5859
- [ ] Important parts of the code are properly commented and documented
59-
- [ ] Code is properly typed with flow
60+
- [ ] Code is properly typed with typescript types
6061
- [ ] React components are split-up enough to avoid unnecessary re-renderings
6162
- [ ] Any code that only works in main process is neatly separated from components
6263

6364
### Testing
65+
6466
- [ ] New feature/change is covered by acceptance tests
6567
- [ ] New feature/change is manually tested and approved by QA team
6668
- [ ] All existing acceptance tests are still up-to-date
6769
- [ ] New feature/change is covered by Daedalus Testing scenario
6870
- [ ] All existing Daedalus Testing scenarios are still up-to-date
6971

7072
### After Review
73+
7174
- [ ] Update Slack QA thread by marking it with a green checkmark

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
### Chores
1313

14+
- Migrated codebase from javascript to typescript ([PR 2843](https://github.com/input-output-hk/daedalus/pull/2843))
1415
- Updated the list of team members ([PR 2805](https://github.com/input-output-hk/daedalus/pull/2805))
1516

1617
## 4.8.0-FC1

0 commit comments

Comments
 (0)