Skip to content

Commit 60514a8

Browse files
committed
Merge branch 'develop' into feature/ddw-745-arm-support
# Conflicts: # installers/common/MacInstaller.hs
2 parents 6051643 + dcaba70 commit 60514a8

35 files changed

+496
-226
lines changed

.gitignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,11 @@ installers/tls/client
4141
installers/tls/server
4242
installers/DLLs
4343
installers/libressl
44+
installers/cfg-files
45+
installers/config.yaml
46+
installers/icons/electron.icns
47+
installers/installer-config.json
48+
installers/topology.yaml
4449

4550
# temporary certs for daedalus dev
4651
tls/client

CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,18 @@
22

33
## vNext
44

5+
### Fixes
6+
7+
- Fixed phrasing of insufficient funds for tokens message ([PR 2966](https://github.com/input-output-hk/daedalus/pull/2966))
8+
9+
## 4.10.0
10+
11+
### Features
12+
13+
- Added support for Ledger Nano S Plus ([PR 2975](https://github.com/input-output-hk/daedalus/pull/2975))
14+
15+
## 4.10.0
16+
517
### Features
618

719
- Implemented hover tooltips for menu ([PR 2938](https://github.com/input-output-hk/daedalus/pull/2938))
@@ -85,6 +97,7 @@
8597

8698
### Fixes
8799

100+
- Improved error handling for incorrect passphrase and incorrect hardware wallet error ([PR 2860](https://github.com/input-output-hk/daedalus/pull/2860))
88101
- Fixed rewards CSV export issues ([PR 2885](https://github.com/input-output-hk/daedalus/pull/2885))
89102
- Fixed behaviour of wallet settings option of the app menu ([PR 2838](https://github.com/input-output-hk/daedalus/pull/2838))
90103
- Fixed styling of ITN rewards feature ([PR 2861](https://github.com/input-output-hk/daedalus/pull/2861))
-107 KB
Binary file not shown.

gulpfile.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,9 @@ gulp.task(
177177
'clean:dist',
178178
'server:create:dev',
179179
'build:renderer:html',
180-
'build:main:watch',
180+
process.argv.includes('--disable-electron-reload')
181+
? 'build:main'
182+
: 'build:main:watch',
181183
'build:renderer:watch'
182184
)
183185
);

hardware-wallet-tests/connect-multiple-hardware-wallets.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ export const run = () => {
1919
createTestInstructions([
2020
'Start test runner',
2121
'Plug Ledger Nano S to your computer',
22+
'Plug Ledger Nano S Plus to your computer',
2223
'Plug Ledger Nano X to your computer',
2324
]);
2425

@@ -27,6 +28,10 @@ export const run = () => {
2728
disconnected: false,
2829
deviceModel: 'nanoS',
2930
},
31+
{
32+
disconnected: false,
33+
deviceModel: 'nanoSP',
34+
},
3035
{
3136
disconnected: false,
3237
deviceModel: 'nanoX',

hardware-wallet-tests/disconnect-multiple-hardware-wallets.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ const getNextExpectedSequence = createSequentialResult([
1414
disconnected: false,
1515
deviceModel: 'nanoS',
1616
},
17+
{
18+
disconnected: false,
19+
deviceModel: 'nanoSP',
20+
},
1721
{
1822
disconnected: false,
1923
deviceModel: 'nanoX',
@@ -22,6 +26,10 @@ const getNextExpectedSequence = createSequentialResult([
2226
disconnected: true,
2327
deviceModel: 'nanoS',
2428
},
29+
{
30+
disconnected: true,
31+
deviceModel: 'nanoSP',
32+
},
2533
{
2634
disconnected: true,
2735
deviceModel: 'nanoX',
@@ -37,8 +45,10 @@ export const run = () => {
3745

3846
createTestInstructions([
3947
'Connect Nano S',
48+
'Connect Nano S Plus',
4049
'Connect Nano X',
4150
'Disconnect Nano S',
51+
'Disconnect Nano S Plus',
4252
'Disconnect Nano X',
4353
]);
4454

installers/common/MacInstaller.hs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,14 +152,16 @@ sign_cmd "$ABS_PATH/Contents/Resources/app/build/usb_bindings.node"
152152
sign_cmd "$ABS_PATH/Contents/Resources/app/build/HID.node"
153153
sign_cmd "$ABS_PATH/Contents/Resources/app/build/detection.node"
154154
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/keccak/bin/darwin-x64-"*"/keccak.node"
155-
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/keccak/bin/darwin-arm64-"*"/keccak.node"
156155
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/keccak/build/Release/addon.node"
157156
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/keccak/prebuilds/darwin-x64/node.napi.node"
158-
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/keccak/prebuilds/darwin-arm64/node.napi.node"
159157
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/blake-hash/prebuilds/darwin-x64/node.napi.node"
160158
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/blake-hash/prebuilds/darwin-arm64/node.napi.node"
159+
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/blake-hash/bin/darwin-x64-"*"/blake-hash.node"
160+
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/blake-hash/build/Release/addon.node"
161161
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/blake2/build/Release/binding.node"
162+
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/blake2/bin/darwin-x64-"*"/blake2.node"
162163
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/tiny-secp256k1/build/Release/secp256k1.node"
164+
sign_cmd "$ABS_PATH/Contents/Resources/app/node_modules/tiny-secp256k1/bin/darwin-x64-"*"/tiny-secp256k1.node"
163165

164166
# Sign the whole component deeply
165167
sign_cmd "$ABS_PATH"

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "daedalus",
33
"productName": "Daedalus",
4-
"version": "4.9.1",
4+
"version": "4.10.0",
55
"description": "Cryptocurrency Wallet",
66
"main": "./dist/main/index.js",
77
"scripts": {
@@ -198,7 +198,7 @@
198198
"dependencies": {
199199
"@cardano-foundation/ledgerjs-hw-app-cardano": "5.0.0",
200200
"@iohk-jormungandr/wallet-js": "0.5.0-pre7",
201-
"@ledgerhq/hw-transport-node-hid": "5.51.1",
201+
"@ledgerhq/hw-transport-node-hid": "6.27.1",
202202
"aes-js": "3.1.2",
203203
"bech32": "2.0.0",
204204
"bignumber.js": "9.0.1",

source/common/types/hardware-wallets.types.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { BridgeInfo, Device as TrezorDevice, UdevInfo } from 'trezor-connect';
22

33
export type BIP32Path = Array<number>;
4-
export type LedgerModel = 'nanoS' | 'nanoX';
4+
export type LedgerModel = 'nanoS' | 'nanoSP' | 'nanoX';
55
export type TrezorModel = '1' | 'T';
66
export type DeviceType = 'ledger' | 'trezor';
77
export type DeviceEvent =
@@ -24,11 +24,13 @@ export type DeviceEvent =
2424
| 'unreadable-device';
2525
export const DeviceModels: {
2626
LEDGER_NANO_S: LedgerModel;
27+
LEDGER_NANO_S_PLUS: LedgerModel;
2728
LEDGER_NANO_X: LedgerModel;
2829
TREZOR_ONE: TrezorModel;
2930
TREZOR_T: TrezorModel;
3031
} = {
3132
LEDGER_NANO_S: 'nanoS',
33+
LEDGER_NANO_S_PLUS: 'nanoSP',
3234
LEDGER_NANO_X: 'nanoX',
3335
TREZOR_ONE: '1',
3436
TREZOR_T: 'T',

0 commit comments

Comments
 (0)