Skip to content

Commit 14088b8

Browse files
[DDW-737] Unify CPU info in diagnostics dialog (#2818)
Co-authored-by: Daniel Main <daniel.main.cernhoff@icloud.com>
1 parent ebb2670 commit 14088b8

File tree

9 files changed

+264
-152
lines changed

9 files changed

+264
-152
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
### Features
66

7+
- Unified CPU info in diagnostics dialog ([PR 2818](https://github.com/input-output-hk/daedalus/pull/2818))
78
- Implemented wallet sorting on sidebar menu ([PR 2775](https://github.com/input-output-hk/daedalus/pull/2775))
89
- Implemented new token picker ([PR 2787](https://github.com/input-output-hk/daedalus/pull/2787))
910

source/common/types/environment.types.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export type Environment = {
2323
mainProcessID: string,
2424
rendererProcessID: string,
2525
os: string,
26-
cpu: string,
26+
cpu: Cpu,
2727
ram: number,
2828
installerVersion: string,
2929
version: string,
@@ -78,3 +78,13 @@ export const networkPrettyNames = {
7878
selfnode: 'Selfnode',
7979
development: 'Development',
8080
};
81+
82+
export type CpuThreadData = {
83+
model: string,
84+
speed: number,
85+
times: {
86+
[string]: number,
87+
},
88+
};
89+
90+
export type Cpu = Array<CpuThreadData>;

source/renderer/app/components/status/DaedalusDiagnostics.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,7 @@ import closeCrossThin from '../../assets/images/close-cross-thin.inline.svg';
1717
import iconCopy from '../../assets/images/clipboard-ic.inline.svg';
1818
import sandClockIcon from '../../assets/images/sand-clock-xs.inline.svg';
1919
import LocalizableError from '../../i18n/LocalizableError';
20-
import {
21-
formattedNumber,
22-
formattedCpuModel,
23-
formattedSize,
24-
} from '../../utils/formatters';
20+
import { formattedNumber, formattedSize } from '../../utils/formatters';
2521
import { CardanoNodeStates } from '../../../../common/types/cardano-node.types';
2622
import styles from './DaedalusDiagnostics.scss';
2723
import type { CardanoNodeState } from '../../../../common/types/cardano-node.types';
@@ -483,12 +479,11 @@ export default class DaedalusDiagnostics extends Component<Props, State> {
483479
const {
484480
platform,
485481
platformVersion,
486-
cpu: cpuInOriginalFormat,
482+
cpu,
487483
ram,
488484
availableDiskSpace: availableDiskSpaceInOriginalFormat,
489485
} = systemInfo;
490486

491-
const cpu = formattedCpuModel(cpuInOriginalFormat);
492487
const availableDiskSpace = formattedSize(
493488
availableDiskSpaceInOriginalFormat
494489
);

source/renderer/app/containers/status/DaedalusDiagnosticsDialog.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import DaedalusDiagnostics from '../../components/status/DaedalusDiagnostics';
66
import styles from './DaedalusDiagnosticsDialog.scss';
77
import { formattedBytesToSize } from '../../utils/formatters';
88
import type { InjectedDialogContainerProps } from '../../types/injectedPropsType';
9+
import formatCpuInfo from '../../utils/formatCpuInfo';
910

1011
type Props = InjectedDialogContainerProps;
1112

@@ -62,7 +63,7 @@ export default class DaedalusDiagnosticsDialog extends Component<Props> {
6263
const systemInfo = {
6364
platform: environment.os,
6465
platformVersion: environment.platformVersion,
65-
cpu: Array.isArray(environment.cpu) ? environment.cpu[0].model : '',
66+
cpu: formatCpuInfo(environment.cpu),
6667
ram: formattedBytesToSize(environment.ram),
6768
availableDiskSpace: diskSpaceAvailable,
6869
};

0 commit comments

Comments
 (0)