Skip to content

Commit f440ebb

Browse files
committed
Improve condition on prefer-lowest
1 parent d0fbec2 commit f440ebb

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

.github/workflows/php-qa.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ on: [push, pull_request]
33
jobs:
44
QA:
55
runs-on: ubuntu-latest
6-
if: "!contains(github.event.head_commit.message, 'ci skip')"
6+
if: ${{ !contains(github.event.head_commit.message, 'ci skip') }}
77

88
strategy:
99
matrix:
1010
php: ['7.0', '7.1', '7.2', '7.3', '7.4']
11-
prefer:
11+
prefer-lowest:
1212
- " --prefer-lowest"
1313
- ""
1414
ignore-platform:
@@ -35,24 +35,24 @@ jobs:
3535
run: find ./src/ ./tests/src/ ./tests/cases/ -type f -name '*.php' -print0 | xargs -0 -L 1 -P 4 -- php -l
3636

3737
- name: Install dependencies
38-
run: composer update -q -n -a --no-progress --prefer-dist${{ matrix.prefer }}${{ matrix.ignore-platform }}
38+
run: composer update -q -n -a --no-progress --prefer-dist${{ matrix.prefer-lowest }}${{ matrix.ignore-platform }}
3939

4040
- name: Run unit tests (>= 7.3)
41-
if: ${{ matrix.php >= 7.3 }}
41+
if: ${{ (matrix.php >= 7.3) && (matrix.prefer-lowest == '') }}
4242
run: ./vendor/bin/phpunit --migrate-configuration
4343

4444
- name: Run unit tests (< 7.3)
4545
if: ${{ matrix.php-versions < 7.3 }}
4646
run: ./vendor/bin/phpunit
4747

4848
- name: Check code styles
49-
if: ${{ matrix.php == '7.4' }}
49+
if: ${{ (matrix.php == '7.4') && (matrix.prefer-lowest == '') }}
5050
run: ./vendor/bin/phpcs
5151

5252
- name: Check cross-version PHP compatibility
53-
if: ${{ matrix.php == '7.4' }}
53+
if: ${{ (matrix.php == '7.4') && (matrix.prefer-lowest == '') }}
5454
run: composer phpcompat
5555

5656
- name: Check Psalm
57-
if: ${{ matrix.php == '7.4' }}
57+
if: ${{ (matrix.php == '7.4') && (matrix.prefer-lowest == '') }}
5858
run: ./vendor/bin/psalm

0 commit comments

Comments
 (0)