Improved ReturnTypeDeclarationSniff

Errors are checked for hook callbacks as well, warnings are not

Author: gmazzap

Inpsyde/Sniffs/CodeQuality/ReturnTypeDeclarationSniff.php

@@ -41,10 +41,6 @@ public function register()
      */
     public function process(File $file, $position)
     {
-        if (Helpers::isHookClosure($file, $position) || Helpers::isHookFunction($file, $position)) {
-            return;
-        }
-
         list($functionStart, $functionEnd) = Helpers::functionBoundaries($file, $position);
         if (!$functionStart < 0 || $functionEnd <= 0) {
             return;
@@ -100,17 +96,21 @@ private function maybeErrors(
             return;
         }
 
-        if ($hasNoReturnType) {
-            $file->addWarning('Return type is missing', $position, 'NoReturnType');
-        }
-
         if ($hasVoidReturnType) {
             $file->addError(
                 'Void return type when returning non-void',
                 $position,
                 'IncorrectVoidReturnType'
             );
         }
+
+        if (Helpers::isHookClosure($file, $position) || Helpers::isHookFunction($file, $position)) {
+            return;
+        }
+
+        if ($hasNoReturnType) {
+            $file->addWarning('Return type is missing', $position, 'NoReturnType');
+        }
     }
 
     /**