Only check public accessors

But configurable

Author: gmazzap

Inpsyde/Sniffs/CodeQuality/NoAccessorsSniff.php

@@ -18,6 +18,7 @@
 use Inpsyde\PhpcsHelpers;
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Sniffs\Sniff;
+use PHP_CodeSniffer\Util\Tokens;
 
 /**
  * @package php-coding-standards
@@ -34,6 +35,8 @@ final class NoAccessorsSniff implements Sniff
 
     public $skipForFunctions = true;
 
+    public $skipForNonPublic = true;
+
     /**
      * @return int[]
      */
@@ -54,11 +57,28 @@ public function process(File $file, $position)
         }
 
         $functionName = $file->getDeclarationName($position);
-
         if (!$functionName || in_array($functionName, self::ALLOWED_NAMES, true)) {
             return;
         }
 
+        if ($this->skipForNonPublic && PhpcsHelpers::functionIsMethod($file, $position)) {
+            $modifierPointerPosition = $file->findPrevious(
+                [T_WHITESPACE, T_ABSTRACT],
+                $position - 1,
+                null,
+                true,
+                null,
+                true
+            );
+            $modifierPointer = $file->getTokens()[$modifierPointerPosition] ?? null;
+            if (!in_array($modifierPointer['code'], Tokens::$scopeModifiers, true)) {
+                $modifierPointer = null;
+            }
+            if ($modifierPointer && $modifierPointer['code'] !== T_PUBLIC) {
+                return;
+            }
+        }
+
         preg_match('/^(set|get)[_A-Z0-9]+/', $functionName, $matches);
         if (!$matches) {
             return;

tests/fixtures/no-accessors.php

@@ -40,8 +40,7 @@ function withThing() {
 
     }
 
-    // @phpcsWarningCodeOnNextLine NoSetter
-    function setTheThing($foo, $bar) {
+    private function setTheThing($foo, $bar) {
 
     }