Fix return type of constructors being checked

Author: gmazzap

Inpsyde/Sniffs/CodeQuality/ReturnTypeDeclarationSniff.php

@@ -36,6 +36,7 @@
 use PHP_CodeSniffer\Sniffs\Sniff;
 use PHP_CodeSniffer\Files\File;
 use PHPCSUtils\Utils\FunctionDeclarations;
+use PHPCSUtils\Utils\ObjectDeclarations;
 use PHPCSUtils\Utils\Scopes;
 
 class ReturnTypeDeclarationSniff implements Sniff
@@ -79,6 +80,14 @@ public function process(File $phpcsFile, $stackPtr): void
         /** @var array<int, array<string, mixed>> $tokens */
         $tokens = $phpcsFile->getTokens();
 
+        // Do not check return type for constructors.
+        if (
+            Scopes::isOOMethod($phpcsFile, $stackPtr)
+            && (ObjectDeclarations::getName($phpcsFile, $stackPtr) === '__construct')
+        ) {
+            return;
+        }
+
         $data = FunctionDeclarations::getProperties($phpcsFile, $stackPtr);
         if (!$data['has_body']) {
             return;

tests/fixtures/return-type-declaration.php

@@ -373,6 +373,15 @@ public function test3(): bool;
 
 class FooAccess implements ArrayAccess
 {
+    private string $x;
+
+    public function __construct(string $x)
+    {
+        if ($x === '') {
+            return;
+        }
+        $this->x = $x;
+    }
 
     /**
      * @inheritdoc