Fix bug in NoAccessorsSniff

Author: gmazzap

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## Not released
+- Fix bug in `NoAccessorsSniff`
+
 ## 0.7.2
 - Fix bug in `ReturnTypeDeclarationSniff` which caused wrong return type detection.
 

Inpsyde/Sniffs/CodeQuality/NoAccessorsSniff.php

@@ -54,7 +54,7 @@ public function process(File $file, $position)
             return;
         }
 
-        preg_match('/^(set|get)[a-zA-Z0-9_\x7f-\xff]+/', $functionName, $matches);
+        preg_match('/^(set|get)[_A-Z0-9]+/', $functionName, $matches);
         if (!$matches) {
             return;
         }
@@ -67,6 +67,8 @@ public function process(File $file, $position)
                 $position,
                 'NoSetter'
             );
+
+            return;
         }
 
         $file->addWarning(

tests/fixtures/no-accessors.php

@@ -2,13 +2,23 @@
 
 // @phpcsSniff CodeQuality.NoAccessors
 
+function getting() {
+
+}
+
+function setting() {
+
+}
+
 interface WithAccessorsInterface {
 
     // @phpcsWarningCodeOnNextLine NoGetter
     function getTheThing();
 
     // @phpcsWarningCodeOnNextLine NoSetter
     function setTheThing($foo, $bar);
+
+    function setting();
 }
 
 class WithAccessors {
@@ -17,6 +27,10 @@ function thing() {
 
     }
 
+    function setting() {
+
+    }
+
     // @phpcsWarningCodeOnNextLine NoGetter
     function getTheThing() {