CS fix and cleanup

Author: gmazzap

Inpsyde/Sniffs/CodeQuality/ForbiddenPublicPropertySniff.php

@@ -49,7 +49,7 @@ public function process(File $file, $position)
             return;
         }
 
-        $scopeModifierToken = $this->getPropertyScopeModifier($file, $position);
+        $scopeModifierToken = $this->propertyScopeModifier($file, $position);
         if ($scopeModifierToken['code'] === T_PUBLIC) {
             $file->addError(
                 'Do not use public properties. Use method access instead.',
@@ -85,12 +85,9 @@ private function isSniffClass(File $file, int $position): bool
      * @param int $position
      * @return mixed[]
      */
-    private function getPropertyScopeModifier(File $file, int $position): array
+    private function propertyScopeModifier(File $file, int $position): array
     {
-        $scopeModifierPosition = $file->findPrevious(
-            Tokens::$scopeModifiers,
-            ($position - 1)
-        );
+        $scopeModifierPosition = $file->findPrevious(Tokens::$scopeModifiers, ($position - 1));
 
         return $file->getTokens()[$scopeModifierPosition];
     }

Inpsyde/Sniffs/CodeQuality/FunctionLengthSniff.php

@@ -58,7 +58,7 @@ public function register()
      */
     public function process(File $file, $position)
     {
-        $length = $this->getStructureLengthInLines($file, $position);
+        $length = $this->structureLinesCount($file, $position);
         if ($length <= $this->maxLength) {
             return;
         }
@@ -90,7 +90,7 @@ public function process(File $file, $position)
      * @param int $position
      * @return int
      */
-    public function getStructureLengthInLines(File $file, int $position): int
+    public function structureLinesCount(File $file, int $position): int
     {
         $tokens = $file->getTokens();
         $token = $tokens[$position] ?? [];

Inpsyde/Sniffs/CodeQuality/NoElseSniff.php

@@ -24,11 +24,6 @@
  */
 final class NoElseSniff implements Sniff
 {
-    /**
-     * @var string
-     */
-    const ERROR_MESSAGE = 'Do not use "else". Prefer early return statement instead.';
-
     /**
      * @return int[]
      */
@@ -43,6 +38,10 @@ public function register()
      */
     public function process(File $file, $position)
     {
-        $file->addWarning(self::ERROR_MESSAGE, $position, 'NoElse');
+        $file->addWarning(
+            'Do not use "else". Prefer early return statement instead.',
+            $position,
+            'ElseFound'
+        );
     }
 }