chore: make key optional on PaginationParams

Author: Evalir

crates/tx-cache/src/client.rs

@@ -106,7 +106,10 @@ impl TxCache {
             .join(join)
             .inspect_err(|e| warn!(%e, "Failed to join URL. Not querying transaction cache."))?;
 
-        let request = self.client.get(url).query(&query.map(|q| q.to_query_object()));
+        let request = self
+            .client
+            .get(url)
+            .query(&query.and_then(|q| q.cursor().map(|c| c.to_query_object())));
 
         // Get the result.
         request

crates/tx-cache/src/types.rs

@@ -545,28 +545,22 @@ impl CursorKey for OrderKey {
 #[derive(Clone, Debug, Serialize, Deserialize, Default)]
 pub struct PaginationParams<C: CursorKey> {
     /// The cursor to start from.
-    cursor: C,
+    cursor: Option<C>,
 }
 
 impl<C: CursorKey> PaginationParams<C> {
     /// Creates a new instance of [`PaginationParams`].
-    pub const fn new(cursor: C) -> Self {
+    pub const fn new(cursor: Option<C>) -> Self {
         Self { cursor }
     }
 
     /// Get the cursor to start from.
-    pub const fn cursor(&self) -> &C {
-        &self.cursor
+    pub const fn cursor(&self) -> Option<&C> {
+        self.cursor.as_ref()
     }
 
     /// Consumes the [`PaginationParams`] and returns the cursor.
-    pub fn into_cursor(self) -> C {
+    pub fn into_cursor(self) -> Option<C> {
         self.cursor
     }
 }
-
-impl<C: CursorKey> CursorKey for PaginationParams<C> {
-    fn to_query_object(&self) -> HashMap<String, String> {
-        self.cursor.to_query_object()
-    }
-}