Commit 7526df9
MyRocks to support both dynamic and static plugins
Upstream commit ID: facebook/mysql-5.6@2a347f6
PS-8755: Merge percona-202301 (https://jira.percona.com/browse/PS-8755)
Summary:
Prior to this diff, fb-mysql MyRocks only supported
static plugins, and used sql_print_* APIs for logging,
which was not available on dynamic plugins.
This diff allows to create either static or dynamic plugins,
depending on -DMYSQL_DYNAMIC_PLUGIN. In addition to that,
adding another option to skip building MyRocks by
-DWITHOUT_ROCKSDB_STORAGE_ENGINE.
Without -DMYSQL_DYNAMIC_PLUGIN, it creates static plugin,
basically the same behavior as before.
With -DMYSQL_DYNAMIC_PLUGIN, it creates dynamic plugin (ha_rocksdb.so).
This diff switched using logging API to LogPluginErrMsg, for both static and dynamic plugins. This slightly changed logging formats, like "[Note] [MY-011071] [Server] Plugin rocksdb reported: 'RocksDB: Column Families at start:'". Prior to the diff, "Plugin rocksdb reported:" was not printed.
Ways to link
with other libraries such as jemalloc are adjusted accordingly.
Reviewed By: lth
Differential Revision: D41313174
fbshipit-source-id: 8a8708b71da379daea13fcae90e3bb1af5d60f321 parent 6b4de17 commit 7526df9
File tree
5 files changed
+66
-59
lines changed- mysql-test/suite/rocksdb
- r
- t
- storage/rocksdb
5 files changed
+66
-59
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
12 | 18 | | |
13 | 19 | | |
14 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
| 107 | + | |
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
366 | 366 | | |
367 | 367 | | |
368 | 368 | | |
369 | | - | |
| 369 | + | |
370 | 370 | | |
371 | 371 | | |
372 | 372 | | |
| |||
381 | 381 | | |
382 | 382 | | |
383 | 383 | | |
384 | | - | |
385 | | - | |
386 | | - | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
387 | 391 | | |
388 | 392 | | |
389 | 393 | | |
| |||
0 commit comments