Skip to content

Commit 7df111f

Browse files
ajkrinikep
authored andcommitted
Update RocksDB usage for 8.0 release
Summary: - Deleted references to removed compressed block cache APIs - Migrated header includes to fix the build Reviewed By: anirbanr-fb Differential Revision: D44207824 fbshipit-source-id: fea5acf
1 parent e3cb1cc commit 7df111f

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

mysql-test/suite/rocksdb/r/rocksdb.result

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1574,8 +1574,6 @@ rocksdb_block_cache_index_bytes_insert #
15741574
rocksdb_block_cache_index_hit #
15751575
rocksdb_block_cache_index_miss #
15761576
rocksdb_block_cache_miss #
1577-
rocksdb_block_cachecompressed_hit #
1578-
rocksdb_block_cachecompressed_miss #
15791577
rocksdb_bloom_filter_full_positive #
15801578
rocksdb_bloom_filter_full_true_positive #
15811579
rocksdb_bloom_filter_prefix_checked #
@@ -1645,8 +1643,6 @@ rocksdb_write_self #
16451643
rocksdb_write_wal #
16461644
select UPPER(VARIABLE_NAME) from performance_schema.global_status where VARIABLE_NAME LIKE 'rocksdb%' and VARIABLE_NAME NOT LIKE '%num_get_for_update%';
16471645
UPPER(VARIABLE_NAME)
1648-
ROCKSDB_BLOCK_CACHECOMPRESSED_HIT
1649-
ROCKSDB_BLOCK_CACHECOMPRESSED_MISS
16501646
ROCKSDB_BLOCK_CACHE_ADD
16511647
ROCKSDB_BLOCK_CACHE_ADD_FAILURES
16521648
ROCKSDB_BLOCK_CACHE_BYTES_READ
@@ -1757,8 +1753,6 @@ ROCKSDB_WRITE_WAL
17571753
# but they are shown as both session and global, like InnoDB's status vars.
17581754
select UPPER(VARIABLE_NAME) from performance_schema.session_status where VARIABLE_NAME LIKE 'rocksdb%' and VARIABLE_NAME NOT LIKE '%num_get_for_update%';
17591755
UPPER(VARIABLE_NAME)
1760-
ROCKSDB_BLOCK_CACHECOMPRESSED_HIT
1761-
ROCKSDB_BLOCK_CACHECOMPRESSED_MISS
17621756
ROCKSDB_BLOCK_CACHE_ADD
17631757
ROCKSDB_BLOCK_CACHE_ADD_FAILURES
17641758
ROCKSDB_BLOCK_CACHE_BYTES_READ

storage/rocksdb/ha_rocksdb.cc

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4960,7 +4960,6 @@ static bool rocksdb_show_status(handlerton *const hton, THD *const thd,
49604960
} else {
49614961
internal_cache_count++;
49624962
}
4963-
cache_set.insert(bbt_opt->block_cache_compressed.get());
49644963
}
49654964
}
49664965
}
@@ -13888,8 +13887,6 @@ struct rocksdb_status_counters_t {
1388813887
uint64_t bloom_filter_prefix_useful;
1388913888
uint64_t number_reseeks_iteration;
1389013889
uint64_t getupdatessince_calls;
13891-
uint64_t block_cachecompressed_miss;
13892-
uint64_t block_cachecompressed_hit;
1389313890
uint64_t wal_synced;
1389413891
uint64_t wal_bytes;
1389513892
uint64_t write_self;
@@ -13958,8 +13955,6 @@ DEF_SHOW_FUNC(bloom_filter_prefix_checked, BLOOM_FILTER_PREFIX_CHECKED)
1395813955
DEF_SHOW_FUNC(bloom_filter_prefix_useful, BLOOM_FILTER_PREFIX_USEFUL)
1395913956
DEF_SHOW_FUNC(number_reseeks_iteration, NUMBER_OF_RESEEKS_IN_ITERATION)
1396013957
DEF_SHOW_FUNC(getupdatessince_calls, GET_UPDATES_SINCE_CALLS)
13961-
DEF_SHOW_FUNC(block_cachecompressed_miss, BLOCK_CACHE_COMPRESSED_MISS)
13962-
DEF_SHOW_FUNC(block_cachecompressed_hit, BLOCK_CACHE_COMPRESSED_HIT)
1396313958
DEF_SHOW_FUNC(wal_synced, WAL_FILE_SYNCED)
1396413959
DEF_SHOW_FUNC(wal_bytes, WAL_FILE_BYTES)
1396513960
DEF_SHOW_FUNC(write_self, WRITE_DONE_BY_SELF)
@@ -14209,8 +14204,6 @@ static SHOW_VAR rocksdb_status_vars[] = {
1420914204
DEF_STATUS_VAR(bloom_filter_prefix_useful),
1421014205
DEF_STATUS_VAR(number_reseeks_iteration),
1421114206
DEF_STATUS_VAR(getupdatessince_calls),
14212-
DEF_STATUS_VAR(block_cachecompressed_miss),
14213-
DEF_STATUS_VAR(block_cachecompressed_hit),
1421414207
DEF_STATUS_VAR(wal_synced),
1421514208
DEF_STATUS_VAR(wal_bytes),
1421614209
DEF_STATUS_VAR(write_self),

storage/rocksdb/rdb_i_s.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@
2828
#include "sql/sql_show.h"
2929

3030
/* RocksDB header files */
31+
#include "rocksdb/version.h"
32+
#if ROCKSDB_MAJOR >= 8
33+
#include "rocksdb/advanced_cache.h"
34+
#endif // ROCKSDB_MAJOR >= 8
3135
#include "rocksdb/compaction_filter.h"
3236
#include "rocksdb/convenience.h"
3337
#include "rocksdb/filter_policy.h"

0 commit comments

Comments
 (0)