refactor: route-53-record to read zone_id from variables

Re-use `acm_record_zone_id` for creating route53 record.

Author: saumitra-dev

main.tf

@@ -377,6 +377,7 @@ module "grafana_backend_rds_security_group" {
 module "grafana_dns_record" {
   source = "./modules/route-53-record"
 
+  zone_id      = var.acm_record_zone_id
   domain       = var.acm_grafana_domain_name
   alb_dns_name = module.grafana_ecs_deployment.alb_dns_name
   alb_zone_id  = module.grafana_ecs_deployment.alb_zone_id

modules/route-53-record/main.tf

@@ -1,20 +1,9 @@
-locals {
-  domain_parts = regexall("(.*\\.)?(.*\\..*)", var.domain)
-  base_domain = (
-    length(local.domain_parts) > 0 && length(local.domain_parts[0]) > 1 ?
-  local.domain_parts[0][1] : var.domain)
-}
-
 ################################################################################
 # ACM Certificate
 ################################################################################
 
-data "aws_route53_zone" "base_domain" {
-  name = local.base_domain
-}
-
 resource "aws_route53_record" "this" {
-  zone_id = data.aws_route53_zone.base_domain.zone_id
+  zone_id = var.zone_id
   name    = var.domain
   type    = "A"
 

modules/route-53-record/outputs.tf

@@ -6,8 +6,3 @@ output "id" {
   description = "Identifier of the Route53 Record"
   value       = aws_route53_record.this.id
 }
-
-output "zone_id" {
-  description = "ID of the Route 53 zone"
-  value       = data.aws_route53_zone.base_domain.zone_id
-}

modules/route-53-record/variables.tf

@@ -2,6 +2,12 @@
 # Route53 Record
 ################################################################################
 
+variable "zone_id" {
+  description = "(Required) The ID of the hosted zone to contain this record."
+  type        = string
+  nullable    = false
+}
+
 variable "domain" {
   description = "(Required) Domain name for which the certificate should be issued."
   type        = string