move resource name evaluation to locals

Author: Premdeep Saini

backup.tf

@@ -1,5 +1,8 @@
 /* Resources for setting up Gitlab remote backup on Amazon S3 */
-
+locals {
+  gitlab_backup_iam_policy_name = "${local.environment_prefix}-gitlab-backup"
+  gitlab_backup_iam_role_name   = "${local.environment_prefix}-gitlab-backup"
+}
 resource "aws_s3_bucket" "gitlab_backup" {
   count  = var.enable_gitlab_backup_to_s3 ? 1 : 0
   bucket = var.gitlab_backup_bucket_name
@@ -64,15 +67,15 @@ data "aws_iam_policy_document" "gitlab_s3_backup" {
 
 resource "aws_iam_policy" "gitlab_backup" {
   count  = var.enable_gitlab_backup_to_s3 ? 1 : 0
-  name   = "${local.environment_prefix}-gitlab-backup"
+  name   = local.gitlab_backup_iam_policy_name
   policy = data.aws_iam_policy_document.gitlab_s3_backup[0].json
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab-backup"
+    Name = local.gitlab_backup_iam_policy_name
   }, local.default_tags, var.additional_tags)
 }
 
 resource "aws_iam_role" "gitlab_backup" {
-  name                = "${local.environment_prefix}-gitlab-backup"
+  name                = local.gitlab_backup_iam_role_name
   assume_role_policy  = <<EOF
 {
     "Version": "2012-10-17",
@@ -90,6 +93,6 @@ resource "aws_iam_role" "gitlab_backup" {
 EOF
   managed_policy_arns = var.enable_gitlab_backup_to_s3 ? [aws_iam_policy.gitlab_backup[0].arn] : []
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab-backup"
+    Name = local.gitlab_backup_iam_role_name
   }, local.default_tags, var.additional_tags)
 }

load_balancers.tf

@@ -1,6 +1,10 @@
 /* Resources for Gitlab classic load balancer */
+locals {
+  gitlab_lb_sg_name = "${local.environment_prefix}-gitlab-lb"
+  gitlab_lb_name    = "${local.environment_prefix}-gitlab"
+}
 resource "aws_security_group" "gitlab_lb" {
-  name        = "${local.environment_prefix}-gitlab-lb"
+  name        = local.gitlab_lb_sg_name
   vpc_id      = data.aws_vpc.vpc.id
   description = "Security group for Gitlab load balancer"
   ingress = [
@@ -52,14 +56,14 @@ resource "aws_security_group" "gitlab_lb" {
     }
   ]
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab-lb"
+    Name = local.gitlab_lb_sg_name
   }, local.default_tags, var.additional_tags)
 }
 
 module "elb" {
   source          = "terraform-aws-modules/elb/aws"
   version         = "~> 2.0"
-  name            = "${local.environment_prefix}-gitlab"
+  name            = local.gitlab_lb_name
   subnets         = var.public_subnet_ids
   security_groups = [aws_security_group.gitlab_lb.id]
   internal        = false
@@ -94,6 +98,6 @@ module "elb" {
   number_of_instances = 1
   instances           = tolist([aws_instance.gitlab.id])
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab"
+    Name = local.gitlab_lb_name
   }, local.default_tags, var.additional_tags)
 }

main.tf

@@ -3,7 +3,11 @@ locals {
     ManagedBy   = "Terraform"
     Environment = var.environment
   }
-  environment_prefix = substr(var.environment, 0, 1)
+  environment_prefix           = substr(var.environment, 0, 1)
+  gitlab_instance_name         = "${local.environment_prefix}-gitlab"
+  gitlab_ssh_key_name          = "${local.environment_prefix}-gitlab-key-pair"
+  gitlab_instance_sg_name      = "${local.environment_prefix}-gitlab"
+  gitlab_instance_profile_name = "${local.environment_prefix}-gitlab"
 }
 
 resource "aws_instance" "gitlab" {
@@ -22,17 +26,17 @@ resource "aws_instance" "gitlab" {
   }
 
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab"
+    Name = local.gitlab_instance_name
   }, local.default_tags, var.additional_tags)
 
 }
 
 resource "aws_key_pair" "gitlab_ssh" {
   count      = var.gitlab_ssh_public_key != null ? 1 : 0
-  key_name   = "${local.environment_prefix}-gitlab-key-pair"
+  key_name   = local.gitlab_ssh_key_name
   public_key = var.gitlab_ssh_public_key
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab-key-pair"
+    Name = local.gitlab_ssh_key_name
   }, local.default_tags, var.additional_tags)
 }
 
@@ -45,7 +49,7 @@ data "aws_route53_zone" "zone" {
 }
 
 resource "aws_security_group" "gitlab" {
-  name        = "${local.environment_prefix}-gitlab"
+  name        = local.gitlab_instance_sg_name
   vpc_id      = data.aws_vpc.vpc.id
   description = "Security group for Gitlab instance"
   ingress = [
@@ -97,7 +101,7 @@ resource "aws_security_group" "gitlab" {
     }
   ]
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab"
+    Name = local.gitlab_instance_sg_name
   }, local.default_tags, var.additional_tags)
 }
 
@@ -134,9 +138,9 @@ module "acm" {
 }
 
 resource "aws_iam_instance_profile" "gitlab" {
-  name = "${local.environment_prefix}-gitlab"
+  name = local.gitlab_instance_profile_name
   role = aws_iam_role.gitlab_backup.name
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab"
+    Name = local.gitlab_instance_profile_name
   }, local.default_tags, var.additional_tags)
 }

rds.tf

@@ -1,6 +1,10 @@
 /* Resources for RDS setup */
+locals {
+  gitlab_rds_cluster_name = "${local.environment_prefix}-gitlab-pg"
+  gitlab_rds_sg_name      = "${local.environment_prefix}-gitlab-rds"
+}
 resource "aws_security_group" "gitlab_rds" {
-  name        = "${local.environment_prefix}-gitlab-rds"
+  name        = local.gitlab_rds_sg_name
   vpc_id      = data.aws_vpc.vpc.id
   description = "Security group for Gitlab RDS"
   ingress = [
@@ -17,13 +21,13 @@ resource "aws_security_group" "gitlab_rds" {
     }
   ]
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab-rds"
+    Name = local.gitlab_rds_sg_name
   }, local.default_tags, var.additional_tags)
 }
 
 module "gitlab_pg" {
   source                    = "terraform-aws-modules/rds/aws"
-  identifier                = "${local.environment_prefix}-gitlab-pg"
+  identifier                = local.gitlab_rds_cluster_name
   create_db_instance        = true
   create_db_subnet_group    = true
   create_db_parameter_group = var.gitlab_pg_create_db_parameter_group
@@ -44,6 +48,6 @@ module "gitlab_pg" {
   publicly_accessible       = var.gitlab_pg_publicly_accessible
   vpc_security_group_ids    = [aws_security_group.gitlab_rds.id]
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab-pg"
+    Name = local.gitlab_rds_cluster_name
   }, local.default_tags, var.additional_tags)
 }

redis.tf

@@ -1,6 +1,11 @@
 /* Resources for Gitlab Redis setup */
+locals {
+  gitlab_redis_sg_name           = "${local.environment_prefix}-gitlab-redis"
+  gitlab_redis_subnet_group_name = "${local.environment_prefix}-gitlab-redis"
+  gitlab_redis_cluster_id        = "${local.environment_prefix}-gitlab-redis"
+}
 resource "aws_security_group" "gitlab_redis" {
-  name        = "${local.environment_prefix}-gitlab-redis"
+  name        = local.gitlab_redis_sg_name
   vpc_id      = data.aws_vpc.vpc.id
   description = "Security group for Gitlab Redis"
   ingress = [
@@ -17,7 +22,7 @@ resource "aws_security_group" "gitlab_redis" {
     }
   ]
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab-redis"
+    Name = local.gitlab_redis_sg_name
   }, local.default_tags, var.additional_tags)
 }
 
@@ -38,11 +43,11 @@ resource "aws_elasticache_parameter_group" "gitlab_redis" {
 
 resource "aws_elasticache_subnet_group" "gitlab_redis" {
   count      = var.gitlab_redis_create_subnet_group == true ? 1 : 0
-  name       = "${local.environment_prefix}-gitlab-redis"
+  name       = local.gitlab_redis_subnet_group_name
   subnet_ids = var.gitlab_redis_subnet_ids
 
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab-redis"
+    Name = local.gitlab_redis_subnet_group_name
   }, local.default_tags, var.additional_tags)
 
   lifecycle {
@@ -54,7 +59,7 @@ resource "aws_elasticache_subnet_group" "gitlab_redis" {
 }
 
 resource "aws_elasticache_cluster" "gitlab_redis" {
-  cluster_id           = "${local.environment_prefix}-gitlab-redis"
+  cluster_id           = local.gitlab_redis_cluster_id
   engine               = "redis"
   node_type            = var.gitlab_redis_node_type
   num_cache_nodes      = var.gitlab_redis_num_cache_nodes
@@ -65,7 +70,7 @@ resource "aws_elasticache_cluster" "gitlab_redis" {
   subnet_group_name    = var.gitlab_redis_create_subnet_group == true ? aws_elasticache_subnet_group.gitlab_redis[0].name : var.gitlab_redis_subnet_group_name
 
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab-redis"
+    Name = local.gitlab_redis_cluster_id
   }, local.default_tags, var.additional_tags)
 
   lifecycle {

ses.tf

@@ -1,4 +1,7 @@
 /* Resources for Amazon SES setup to be used as SMTP service for Gitlab */
+locals {
+  gitlab_ses_sender_name = "${local.environment_prefix}-gitlab-ses-sender"
+}
 data "aws_route53_zone" "email_domain" {
   count = var.create_ses_identity ? 1 : 0
   name  = var.ses_domain != null ? var.ses_domain : var.hosted_zone
@@ -45,11 +48,11 @@ data "aws_iam_policy_document" "gitlab_ses_sender" {
 
 resource "aws_iam_policy" "gitlab_ses_sender" {
   count       = var.create_ses_identity ? 1 : 0
-  name        = "${local.environment_prefix}-gitlab-ses-sender"
+  name        = local.gitlab_ses_sender_name
   description = "Allows sending of e-mails via Simple Email Service"
   policy      = data.aws_iam_policy_document.gitlab_ses_sender[0].json
   tags = merge({
-    Name = "${local.environment_prefix}-gitlab-ses-sender"
+    Name = local.gitlab_ses_sender_name
   }, local.default_tags, var.additional_tags)
 }