fix(modules/asg): user_data cannot be null

Change variables and outputs descriptions. Update Terraform and AWS Provider version.

Author: saumitra-dev

modules/asg/README.md

@@ -5,7 +5,8 @@
 
 | Name | Version |
 |------|---------|
-| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.6.0 |
+| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >=  1.8.4 |
+| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 5.51.0 |
 
 ## Providers
 
@@ -34,30 +35,30 @@ No modules.
 |------|-------------|------|---------|:--------:|
 | <a name="input_cluster_name"></a> [cluster\_name](#input\_cluster\_name) | Name of the ECS Cluster to associate with the Autoscaling Group | `string` | n/a | yes |
 | <a name="input_create_launch_template"></a> [create\_launch\_template](#input\_create\_launch\_template) | Either to create a Launch Template to associate with the Autoscaling group | `bool` | `true` | no |
-| <a name="input_desired_capacity"></a> [desired\_capacity](#input\_desired\_capacity) | Desired capacity for the Autoscaling group | `number` | n/a | yes |
-| <a name="input_iam_instance_profile_name"></a> [iam\_instance\_profile\_name](#input\_iam\_instance\_profile\_name) | Name of the IAM Instance Profile | `string` | `null` | no |
-| <a name="input_iam_instance_profile_tags"></a> [iam\_instance\_profile\_tags](#input\_iam\_instance\_profile\_tags) | Resource Tags for the IAM Instance Profile | `map(any)` | `{}` | no |
-| <a name="input_iam_role_name"></a> [iam\_role\_name](#input\_iam\_role\_name) | Name for the IAM Role | `string` | `null` | no |
-| <a name="input_iam_role_policy_attachments"></a> [iam\_role\_policy\_attachments](#input\_iam\_role\_policy\_attachments) | Policy ARNs to attach to the IAM Role | `list(string)` | <pre>[<br>  "arn:aws:iam::aws:policy/service-role/AmazonEC2ContainerServiceforEC2Role"<br>]</pre> | no |
-| <a name="input_iam_role_tags"></a> [iam\_role\_tags](#input\_iam\_role\_tags) | Resource Tags for IAM Role | `map(any)` | `{}` | no |
+| <a name="input_desired_capacity"></a> [desired\_capacity](#input\_desired\_capacity) | The number of Amazon EC2 instances that should be running in the group. | `number` | n/a | yes |
+| <a name="input_iam_instance_profile_name"></a> [iam\_instance\_profile\_name](#input\_iam\_instance\_profile\_name) | (Optional, Forces new resource) Name of the instance profile. | `string` | `null` | no |
+| <a name="input_iam_instance_profile_tags"></a> [iam\_instance\_profile\_tags](#input\_iam\_instance\_profile\_tags) | (Optional) Map of resource tags for the IAM Instance Profile. | `map(any)` | `{}` | no |
+| <a name="input_iam_role_name"></a> [iam\_role\_name](#input\_iam\_role\_name) | (Optional, Forces new resource) Friendly name of the role. | `string` | `null` | no |
+| <a name="input_iam_role_policy_attachments"></a> [iam\_role\_policy\_attachments](#input\_iam\_role\_policy\_attachments) | (Required) - The ARN of the policy you want to apply | `list(string)` | <pre>[<br>  "arn:aws:iam::aws:policy/service-role/AmazonEC2ContainerServiceforEC2Role"<br>]</pre> | no |
+| <a name="input_iam_role_tags"></a> [iam\_role\_tags](#input\_iam\_role\_tags) | Key-value mapping of tags for the IAM role. | `map(any)` | `{}` | no |
 | <a name="input_instances_tags"></a> [instances\_tags](#input\_instances\_tags) | Resources Tags to propagate to the Instances | `map(any)` | `{}` | no |
 | <a name="input_launch_template"></a> [launch\_template](#input\_launch\_template) | Launch Template to use with the Autoscaling group | <pre>object({<br>    name                   = optional(string, null)<br>    image_id               = optional(string, null)<br>    instance_type          = optional(string, null)<br>    vpc_security_group_ids = optional(list(string), [])<br>    key_name               = optional(string, null)<br>    user_data              = optional(string, null)<br>    tags                   = optional(map(any), {})<br>  })</pre> | `{}` | no |
 | <a name="input_launch_template_id"></a> [launch\_template\_id](#input\_launch\_template\_id) | Identifier of the Launch Template | `string` | `null` | no |
-| <a name="input_max_size"></a> [max\_size](#input\_max\_size) | Max. size for the Autoscaling group | `number` | n/a | yes |
-| <a name="input_min_size"></a> [min\_size](#input\_min\_size) | Min. size for the Autoscaling group | `number` | n/a | yes |
-| <a name="input_name"></a> [name](#input\_name) | Name of the Autoscaling Group | `string` | n/a | yes |
+| <a name="input_max_size"></a> [max\_size](#input\_max\_size) | Maximum size of the Auto Scaling Group | `number` | n/a | yes |
+| <a name="input_min_size"></a> [min\_size](#input\_min\_size) | Minimum size of the Auto Scaling Group | `number` | n/a | yes |
+| <a name="input_name"></a> [name](#input\_name) | (Optional) Name of the Auto Scaling Group. | `string` | n/a | yes |
 | <a name="input_tags"></a> [tags](#input\_tags) | Resources Tags for Autoscaling group | `map(any)` | `{}` | no |
-| <a name="input_vpc_zone_identifier"></a> [vpc\_zone\_identifier](#input\_vpc\_zone\_identifier) | Identifiers of the VPC Subnets | `list(string)` | n/a | yes |
+| <a name="input_vpc_zone_identifier"></a> [vpc\_zone\_identifier](#input\_vpc\_zone\_identifier) | (Optional) List of subnet IDs to launch resources in. | `list(string)` | n/a | yes |
 
 ## Outputs
 
 | Name | Description |
 |------|-------------|
-| <a name="output_arn"></a> [arn](#output\_arn) | ARN of the Autoscaling group |
-| <a name="output_iam_instance_profile_arn"></a> [iam\_instance\_profile\_arn](#output\_iam\_instance\_profile\_arn) | ARN of the IAM Instance Profile |
-| <a name="output_iam_instance_profile_id"></a> [iam\_instance\_profile\_id](#output\_iam\_instance\_profile\_id) | Identifier of the IAM Instance Profile |
-| <a name="output_iam_role_id"></a> [iam\_role\_id](#output\_iam\_role\_id) | Identifier of the IAM Role |
-| <a name="output_id"></a> [id](#output\_id) | Identifier of the Autoscaling group |
-| <a name="output_launch_template_arn"></a> [launch\_template\_arn](#output\_launch\_template\_arn) | ARN of the Launch Template |
-| <a name="output_launch_template_id"></a> [launch\_template\_id](#output\_launch\_template\_id) | Identifier of the Launch Template |
+| <a name="output_arn"></a> [arn](#output\_arn) | ARN for this Auto Scaling Group. |
+| <a name="output_iam_instance_profile_arn"></a> [iam\_instance\_profile\_arn](#output\_iam\_instance\_profile\_arn) | ARN assigned by AWS to the instance profile. |
+| <a name="output_iam_instance_profile_id"></a> [iam\_instance\_profile\_id](#output\_iam\_instance\_profile\_id) | Instance profile's ID. |
+| <a name="output_iam_role_id"></a> [iam\_role\_id](#output\_iam\_role\_id) | Name of the role. |
+| <a name="output_id"></a> [id](#output\_id) | Auto Scaling Group id. |
+| <a name="output_launch_template_arn"></a> [launch\_template\_arn](#output\_launch\_template\_arn) | Amazon Resource Name (ARN) of the launch template. |
+| <a name="output_launch_template_id"></a> [launch\_template\_id](#output\_launch\_template\_id) | The ID of the launch template. |
 <!-- END_TF_DOCS -->

modules/asg/main.tf

@@ -53,14 +53,11 @@ resource "aws_launch_template" "this" {
     name = aws_iam_instance_profile.this.name
   }
 
-  user_data = base64encode(
-    try(
-      var.launch_template.user_data,
-      <<-USERDATA
-        #!/bin/bash
-        echo ECS_CLUSTER="${var.cluster_name}" >> /etc/ecs/ecs.config
-      USERDATA
-    )
+  user_data = try(var.launch_template.user_data, null) != null ? base64encode(var.launch_template.user_data) : base64encode(
+    <<-USERDATA
+      #!/bin/bash
+      echo ECS_CLUSTER="${var.cluster_name}" >> /etc/ecs/ecs.config
+    USERDATA
   )
 
   tags = var.launch_template.tags

modules/asg/outputs.tf

@@ -1,10 +1,10 @@
 output "id" {
-  description = "Identifier of the Autoscaling group"
+  description = "Auto Scaling Group id."
   value       = aws_autoscaling_group.this.id
 }
 
 output "arn" {
-  description = "ARN of the Autoscaling group"
+  description = "ARN for this Auto Scaling Group."
   value       = aws_autoscaling_group.this.arn
 }
 
@@ -13,12 +13,12 @@ output "arn" {
 ################################################################################
 
 output "launch_template_id" {
-  description = "Identifier of the Launch Template"
+  description = "The ID of the launch template."
   value       = var.create_launch_template ? aws_launch_template.this[0].id : var.launch_template_id
 }
 
 output "launch_template_arn" {
-  description = "ARN of the Launch Template"
+  description = "Amazon Resource Name (ARN) of the launch template."
   value       = var.create_launch_template ? aws_launch_template.this[0].arn : null
 }
 
@@ -27,16 +27,16 @@ output "launch_template_arn" {
 ################################################################################
 
 output "iam_role_id" {
-  description = "Identifier of the IAM Role"
+  description = "Name of the role."
   value       = aws_iam_role.this.id
 }
 
 output "iam_instance_profile_id" {
-  description = "Identifier of the IAM Instance Profile"
+  description = "Instance profile's ID."
   value       = aws_iam_instance_profile.this.id
 }
 
 output "iam_instance_profile_arn" {
-  description = "ARN of the IAM Instance Profile"
+  description = "ARN assigned by AWS to the instance profile."
   value       = aws_iam_instance_profile.this.arn
 }

modules/asg/variables.tf

@@ -4,27 +4,27 @@ variable "cluster_name" {
 }
 
 variable "name" {
-  description = "Name of the Autoscaling Group"
+  description = "(Optional) Name of the Auto Scaling Group."
   type        = string
 }
 
 variable "vpc_zone_identifier" {
-  description = "Identifiers of the VPC Subnets"
+  description = "(Optional) List of subnet IDs to launch resources in."
   type        = list(string)
 }
 
 variable "desired_capacity" {
-  description = "Desired capacity for the Autoscaling group"
+  description = "The number of Amazon EC2 instances that should be running in the group."
   type        = number
 }
 
 variable "min_size" {
-  description = "Min. size for the Autoscaling group"
+  description = "Minimum size of the Auto Scaling Group"
   type        = number
 }
 
 variable "max_size" {
-  description = "Max. size for the Autoscaling group"
+  description = "Maximum size of the Auto Scaling Group"
   type        = number
 }
 
@@ -75,21 +75,21 @@ variable "launch_template_id" {
 ################################################################################
 
 variable "iam_role_name" {
-  description = "Name for the IAM Role"
+  description = "(Optional, Forces new resource) Friendly name of the role."
   type        = string
   default     = null
 }
 
 variable "iam_role_policy_attachments" {
-  description = "Policy ARNs to attach to the IAM Role"
+  description = "(Required) - The ARN of the policy you want to apply"
   type        = list(string)
   default = [
     "arn:aws:iam::aws:policy/service-role/AmazonEC2ContainerServiceforEC2Role"
   ]
 }
 
 variable "iam_role_tags" {
-  description = "Resource Tags for IAM Role"
+  description = "Key-value mapping of tags for the IAM role."
   type        = map(any)
   default     = {}
 }
@@ -99,13 +99,13 @@ variable "iam_role_tags" {
 ################################################################################
 
 variable "iam_instance_profile_name" {
-  description = "Name of the IAM Instance Profile"
+  description = "(Optional, Forces new resource) Name of the instance profile."
   type        = string
   default     = null
 }
 
 variable "iam_instance_profile_tags" {
-  description = "Resource Tags for the IAM Instance Profile"
+  description = "(Optional) Map of resource tags for the IAM Instance Profile."
   type        = map(any)
   default     = {}
 }

modules/asg/version.tf

@@ -1,3 +1,10 @@
 terraform {
-  required_version = ">= 1.6.0"
+  required_version = ">=  1.8.4"
+
+  required_providers {
+    aws = {
+      source  = "hashicorp/aws"
+      version = ">= 5.51.0"
+    }
+  }
 }