Fixed issue when parsing enums in query parameters.

Author: lvukadinovic-ib

ApiClient.Tests/Api/ApiTest.cs

@@ -1,3 +1,4 @@
+using System.Globalization;
 using System.Reflection;
 using System.Runtime.Serialization;
 using Infobip.Api.Client;
@@ -29,6 +30,8 @@ public class ApiTest
     [TestInitialize]
     public void StartMockServer()
     {
+        CultureInfo.DefaultThreadCurrentCulture = CultureInfo.InvariantCulture;
+        
         wireMockServer = WireMockServer.Start();
 
         configuration = new Configuration

ApiClient.Tests/Api/CallsApiTest.cs

@@ -6430,7 +6430,7 @@ public void ShouldGetCallRecordings()
         var givenLocation = CallsRecordingLocation.Frankfurt;
         var givenQueryParameters = new Dictionary<string, string>
         {
-            { "location", givenLocation.ToString() }
+            { "location", GetEnumAttributeValue(givenLocation) }
         };
 
         var givenResponse = @"
@@ -6505,7 +6505,7 @@ public void ShouldDeleteCallRecordings()
         var givenLocation = CallsRecordingLocation.Frankfurt;
         var givenQueryParameters = new Dictionary<string, string>
         {
-            { "location", givenLocation.ToString() }
+            { "location", GetEnumAttributeValue(givenLocation) }
         };
 
         var givenResponse = @"
@@ -6814,7 +6814,7 @@ public void ShouldGetConferenceRecordings()
         var givenLocation = CallsRecordingLocation.Frankfurt;
         var givenQueryParameters = new Dictionary<string, string>
         {
-            { "location", givenLocation.ToString() }
+            { "location", GetEnumAttributeValue(givenLocation) }
         };
 
         var givenResponse = @"
@@ -7000,7 +7000,7 @@ public void ShouldDeleteConferenceRecording()
         var givenLocation = CallsRecordingLocation.Frankfurt;
         var givenQueryParameters = new Dictionary<string, string>
         {
-            { "location", givenLocation.ToString() }
+            { "location", GetEnumAttributeValue(givenLocation) }
         };
 
         var givenResponse = @"
@@ -7186,7 +7186,7 @@ public void ShouldComposeConferenceRecordingOnCalls()
         var givenLocation = CallsRecordingLocation.Frankfurt;
         var givenQueryParameters = new Dictionary<string, string>
         {
-            { "location", givenLocation.ToString() }
+            { "location", GetEnumAttributeValue(givenLocation) }
         };
 
         var givenRequest = @"
@@ -7457,7 +7457,7 @@ public void ShouldGetDialogRecordings()
         var givenLocation = CallsRecordingLocation.Frankfurt;
         var givenQueryParameters = new Dictionary<string, string>
         {
-            { "location", givenLocation.ToString() }
+            { "location", GetEnumAttributeValue(givenLocation) }
         };
 
         var givenResponse = @"
@@ -7639,7 +7639,7 @@ public void ShouldDeleteDialogRecordings()
         var givenLocation = CallsRecordingLocation.Frankfurt;
         var givenQueryParameters = new Dictionary<string, string>
         {
-            { "location", givenLocation.ToString() }
+            { "location", GetEnumAttributeValue(givenLocation) }
         };
 
         var givenResponse = @"
@@ -7821,7 +7821,7 @@ public void ShouldComposeDialogRecordingOnCalls()
         var givenLocation = CallsRecordingLocation.Frankfurt;
         var givenQueryParameters = new Dictionary<string, string>
         {
-            { "location", givenLocation.ToString() }
+            { "location", GetEnumAttributeValue(givenLocation) }
         };
 
         var givenRequest = @"
@@ -7865,7 +7865,7 @@ public void ShouldDeleteRecordingFile()
         var givenLocation = CallsRecordingLocation.Frankfurt;
         var givenQueryParameters = new Dictionary<string, string>
         {
-            { "location", givenLocation.ToString() }
+            { "location", GetEnumAttributeValue(givenLocation) }
         };
 
         var givenResponse = @"

ApiClient.Tests/Api/EmailApiTest.cs

@@ -1107,7 +1107,7 @@ public void ShouldGetSuppresions()
         var givenQueryParameters = new Dictionary<string, string>
         {
             { "domainName", expectedEmailAddress },
-            { "type", givenType.ToString() },
+            { "type", GetEnumAttributeValue(EmailSuppressionType.Bounce) },
             { "page", givenPage.ToString() },
             { "size", givenSize.ToString() }
         };
@@ -1134,16 +1134,16 @@ void AssertEmailSuppressionInfoPageResponse(EmailSuppressionInfoPageResponse ema
             Assert.AreEqual(expectedSize, emailSuppressionInfoPageResponse.Paging.Size);
         }
 
-        AssertResponse(emailApi.GetSuppressions(givenDomainName, givenType),
+        AssertResponse(emailApi.GetSuppressions(domainName: givenDomainName, type: givenType, page: givenPage, size:givenSize),
             AssertEmailSuppressionInfoPageResponse);
-        AssertResponse(emailApi.GetSuppressionsAsync(givenDomainName, givenType).Result,
+        AssertResponse(emailApi.GetSuppressionsAsync(domainName: givenDomainName, type: givenType, page: givenPage, size:givenSize).Result,
             AssertEmailSuppressionInfoPageResponse);
 
         AssertResponseWithHttpInfo(
-            emailApi.GetSuppressionsWithHttpInfo(givenDomainName, givenType),
+            emailApi.GetSuppressionsWithHttpInfo(domainName: givenDomainName, type: givenType, page: givenPage, size:givenSize),
             AssertEmailSuppressionInfoPageResponse, 200);
         AssertResponseWithHttpInfo(
-            emailApi.GetSuppressionsWithHttpInfoAsync(givenDomainName, givenType).Result,
+            emailApi.GetSuppressionsWithHttpInfoAsync(domainName: givenDomainName, type: givenType, page: givenPage, size:givenSize).Result,
             AssertEmailSuppressionInfoPageResponse, 200);
     }
 

ApiClient.Tests/Api/SmsApiTest.cs

@@ -1027,10 +1027,10 @@ public void ShouldGetOutboundLogs()
         }}";
 
         SetUpGetRequest(SMS_LOGS_ENDPOINT, 200, expectedResponse,
-            new Dictionary<string, string> { { "bulkId", bulkId } });
+            new Dictionary<string, string> { { "bulkId", bulkId }, {"generalStatus", GetEnumAttributeValue(MessageGeneralStatus.Accepted)}});
 
         var smsApiClient = new SmsApi(configuration);
-        var actualResponse = smsApiClient.GetOutboundSmsMessageLogs(bulkId: new List<string> { bulkId });
+        var actualResponse = smsApiClient.GetOutboundSmsMessageLogs(bulkId: new List<string> {bulkId}, generalStatus: MessageGeneralStatus.Accepted);
 
         var expectedDeserializedLogs = new SmsLogsResponse(new List<SmsLog>
         {

src/Infobip.Api.Client/Client/ClientUtils.cs

@@ -14,6 +14,8 @@
 using System.Globalization;
 using System.IO;
 using System.Linq;
+using System.Reflection;
+using System.Runtime.Serialization;
 using System.Text;
 using System.Text.RegularExpressions;
 
@@ -117,10 +119,29 @@ public static string ParameterToString(object obj)
                 return boolean ? "true" : "false";
             if (obj is ICollection collection)
                 return string.Join(",", collection.Cast<object>());
+            if (obj is Enum)
+                return EnumToString(obj);
 
             return Convert.ToString(obj, CultureInfo.InvariantCulture);
         }
 
+        /// <summary>
+        ///     Returns the string value of an enum, preferring [EnumMember(Value=...)] if present, otherwise ToString().
+        /// </summary>
+        /// <param name="enumValue">The enum value to be transformed into string.</param>
+        /// <returns>A string representation of the enum value.</returns>
+        public static string EnumToString(object enumValue)
+        {
+            var type = enumValue.GetType();
+            var enumType = Nullable.GetUnderlyingType(type) ?? type;
+            if (!enumType.IsEnum)
+                return Convert.ToString(enumValue, CultureInfo.InvariantCulture);
+            var name = Convert.ToString(enumValue, CultureInfo.InvariantCulture);
+            var member = enumType.GetMember(name).FirstOrDefault();
+            var attr = member?.GetCustomAttribute<EnumMemberAttribute>();
+            return attr?.Value ?? name.ToUpperInvariant();
+        }
+
         /// <summary>
         ///     Convert stream to byte array
         /// </summary>