From 1d7e9fd9917c9c8864711b4db3d14a2654874ad1 Mon Sep 17 00:00:00 2001
From: Torben Hansen <derhansen@gmail.com>
Date: Wed, 16 Oct 2019 16:27:17 +0200
Subject: [PATCH 1/3] [TASK] Remove autocomplete attribute from HoneyPot
 partial

The configured value `new-powermail-hp` for the autocomplete
attribute is invalid and fails in the accessibility check
provided by accessibilityinsights.io

Valid values for autofill:
https://www.w3.org/TR/html52/sec-forms.html#autofilling-form-controls-the-autocomplete-attribute
---
 Resources/Private/Partials/Misc/HoneyPod.html | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Resources/Private/Partials/Misc/HoneyPod.html b/Resources/Private/Partials/Misc/HoneyPod.html
index 36243bf45..a350d9522 100644
--- a/Resources/Private/Partials/Misc/HoneyPod.html
+++ b/Resources/Private/Partials/Misc/HoneyPod.html
@@ -8,7 +8,6 @@
 		<f:form.textfield
 				name="field[__hp]"
 				value=""
-				id="powermail_hp_{form.uid}"
-				additionalAttributes="{autocomplete: 'new-powermail-hp'}" />
+				id="powermail_hp_{form.uid}" />
 	</div>
 </f:if>

From 3a9a6a4a96511ebd48a570abee72ee7aa273c775 Mon Sep 17 00:00:00 2001
From: Torben Hansen <derhansen@gmail.com>
Date: Sat, 23 Nov 2019 05:37:31 +0100
Subject: [PATCH 2/3] [TASK] Hide honeypot field from screenreaders

Added additional attributes to honeypot textfield, so it will be
ignored by screenreaders.
---
 Resources/Private/Partials/Misc/HoneyPod.html | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Resources/Private/Partials/Misc/HoneyPod.html b/Resources/Private/Partials/Misc/HoneyPod.html
index a350d9522..50505e3ff 100644
--- a/Resources/Private/Partials/Misc/HoneyPod.html
+++ b/Resources/Private/Partials/Misc/HoneyPod.html
@@ -8,6 +8,8 @@
 		<f:form.textfield
 				name="field[__hp]"
 				value=""
-				id="powermail_hp_{form.uid}" />
+				id="powermail_hp_{form.uid}"
+				tabindex="-1"
+				additionalAttributes="{autocomplete: 'powermail-hp-{form.uid}', aria-hidden: 'true'}" />
 	</div>
 </f:if>

From e9f1319a70a9dcd66df86195201f70abaf31b529 Mon Sep 17 00:00:00 2001
From: Torben Hansen <derhansen@gmail.com>
Date: Sat, 23 Nov 2019 14:09:25 +0100
Subject: [PATCH 3/3] [TASK] Include "new" in autocomplete honeypot value

---
 Resources/Private/Partials/Misc/HoneyPod.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Resources/Private/Partials/Misc/HoneyPod.html b/Resources/Private/Partials/Misc/HoneyPod.html
index 50505e3ff..9db22c5fc 100644
--- a/Resources/Private/Partials/Misc/HoneyPod.html
+++ b/Resources/Private/Partials/Misc/HoneyPod.html
@@ -10,6 +10,6 @@
 				value=""
 				id="powermail_hp_{form.uid}"
 				tabindex="-1"
-				additionalAttributes="{autocomplete: 'powermail-hp-{form.uid}', aria-hidden: 'true'}" />
+				additionalAttributes="{autocomplete: 'new-powermail-hp-{form.uid}', aria-hidden: 'true'}" />
 	</div>
 </f:if>