Skip to content

Commit b98683d

Browse files
committed
[BUGFIX] Fix php annotations
Some php comments contained false return types. This is fixed now. Signed-off-by: Marcus Schwemer <marcus.schwemer@in2code.de>
1 parent 988a162 commit b98683d

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

Classes/Controller/FormController.php

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class FormController extends AbstractController
5959
protected $dataProcessorRunner;
6060

6161
/**
62-
* @return void
62+
* @return ResponseInterface
6363
* @throws InvalidSlotException
6464
* @throws InvalidSlotReturnException
6565
* @throws Exception
@@ -122,7 +122,7 @@ public function initializeConfirmationAction(): void
122122
* @ExtbaseAnnotation\Validate("In2code\Powermail\Domain\Validator\UniqueValidator", param="mail")
123123
* @ExtbaseAnnotation\Validate("In2code\Powermail\Domain\Validator\ForeignValidator", param="mail")
124124
* @ExtbaseAnnotation\Validate("In2code\Powermail\Domain\Validator\CustomValidator", param="mail")
125-
* @return void
125+
* @return ResponseInterface
126126
* @throws InvalidConfigurationTypeException
127127
* @throws InvalidExtensionNameException
128128
* @throws InvalidSlotException
@@ -180,7 +180,7 @@ public function initializeCreateAction(): void
180180
* @ExtbaseAnnotation\Validate("In2code\Powermail\Domain\Validator\UniqueValidator", param="mail")
181181
* @ExtbaseAnnotation\Validate("In2code\Powermail\Domain\Validator\ForeignValidator", param="mail")
182182
* @ExtbaseAnnotation\Validate("In2code\Powermail\Domain\Validator\CustomValidator", param="mail")
183-
* @return void
183+
* @return ResponseInterface
184184
* @throws IllegalObjectTypeException
185185
* @throws InvalidConfigurationTypeException
186186
* @throws InvalidExtensionNameException
@@ -322,10 +322,9 @@ protected function saveMail(Mail $mail): void
322322
*
323323
* @param int $mail mail uid
324324
* @param string $hash Given Hash String
325-
* @return void
325+
* @return ResponseInterface
326326
* @throws InvalidSlotException
327327
* @throws InvalidSlotReturnException
328-
* @throws StopActionException
329328
* @throws IllegalObjectTypeException
330329
* @throws UnknownObjectException
331330
* @throws Exception
@@ -361,7 +360,7 @@ public function optinConfirmAction(int $mail, string $hash): ResponseInterface
361360
/**
362361
* @param int $mail
363362
* @param string $hash
364-
* @return void
363+
* @return ResponseInterface
365364
* @throws \Exception
366365
* @noinspection PhpUnused
367366
*/
@@ -386,7 +385,7 @@ public function disclaimerAction(int $mail, string $hash): ResponseInterface
386385
* @param int $language Frontend Language Uid
387386
* @param int $pid Page Id
388387
* @param bool $mobileDevice Is mobile device?
389-
* @return string
388+
* @return ResponseInterface
390389
* @noinspection PhpUnused
391390
* @codeCoverageIgnore
392391
*/
@@ -458,7 +457,6 @@ protected function forwardIfFormParamsDoNotMatch(): void
458457
* Forward to formAction if no mail param given
459458
*
460459
* @return ForwardResponse|null
461-
* @throws StopActionException
462460
*/
463461
protected function forwardIfMailParamEmpty(): ?ForwardResponse
464462
{
@@ -478,7 +476,6 @@ protected function forwardIfMailParamEmpty(): ?ForwardResponse
478476
*
479477
* @param Mail|null $mail
480478
* @return ResponseInterface|null
481-
* @throws StopActionException
482479
*/
483480
protected function forwardIfFormParamsDoNotMatchForOptinConfirm(Mail $mail = null): ?ResponseInterface
484481
{
@@ -500,8 +497,7 @@ protected function forwardIfFormParamsDoNotMatchForOptinConfirm(Mail $mail = nul
500497
* a validator for createAction fails, confirmationAction is called (if function is turned on) and same validators
501498
* are firing again
502499
*
503-
* @return void
504-
* @throws StopActionException
500+
* @return ResponseInterface|null
505501
*/
506502
protected function forwardToReferringRequest(): ?ResponseInterface
507503
{

0 commit comments

Comments
 (0)