don't use yoda conditions

vertexvaar · einpraegsam · commit 6dea8050b9e4 · 2021-03-08T11:15:01.000+01:00
diff --git a/Classes/Domain/Validator/CaptchaValidator.php b/Classes/Domain/Validator/CaptchaValidator.php
@@ -59,7 +59,7 @@ public function isValid($mail)
                      * Resolves: https://github.com/einpraegsam/powermail/issues/376
                      * Resolves: https://projekte.in2code.de/issues/44174
                      */
-                    if (null === $answer->getUid()) {
+                    if ($answer->getUid() === null) {
                         if (!$this->validCodePreflight($answer->getValue(), $answer->getField())) {
                             $this->setErrorAndMessage($answer->getField(), 'captcha');
                         }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public function isValid($mail)`
`59`	`59`	`* Resolves: https://github.com/einpraegsam/powermail/issues/376`
`60`	`60`	`* Resolves: https://projekte.in2code.de/issues/44174`
`61`	`61`	`*/`
`62`		`- if (null === $answer->getUid()) {`
	`62`	`+ if ($answer->getUid() === null) {`
`63`	`63`	`if (!$this->validCodePreflight($answer->getValue(), $answer->getField())) {`
`64`	`64`	`$this->setErrorAndMessage($answer->getField(), 'captcha');`
`65`	`65`	`}`