Skip to content

Commit 59eaddb

Browse files
authored
Merge pull request ChargeTimeEU#150 from codibly/bugfix/rename-changing-to-charging-in-charging-rate-unit-type
Rename enum ChangingRateUnitType to ChargingRateUnitType (Typo)
2 parents 2e7cb69 + 6098c90 commit 59eaddb

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ of this software and associated documentation files (the "Software"), to deal
2525
SOFTWARE.
2626
*/
2727

28-
public enum ChangingRateUnitType {
28+
public enum ChargingRateUnitType {
2929
W,
3030
A
3131
}

ocpp-v1_6/src/main/java/eu/chargetime/ocpp/model/smartcharging/GetCompositeScheduleRequest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public class GetCompositeScheduleRequest implements Request {
3838

3939
private Integer connectorId;
4040
private Integer duration;
41-
private ChangingRateUnitType changingRateUnitType;
41+
private ChargingRateUnitType chargingRateUnit;
4242

4343
/**
4444
* @deprecated use {@link #GetCompositeScheduleRequest(Integer, Integer)} to be sure to set
@@ -107,18 +107,18 @@ public void setDuration(Integer duration) {
107107
*
108108
* @return current profile
109109
*/
110-
public ChangingRateUnitType getChangingRateUnitType() {
111-
return changingRateUnitType;
110+
public ChargingRateUnitType getChargingRateUnit() {
111+
return chargingRateUnit;
112112
}
113113

114114
/**
115115
* Optional. Can be used to force a power or current profile
116116
*
117-
* @param changingRateUnitType the {@link ChangingRateUnitType}
117+
* @param chargingRateUnit the {@link ChargingRateUnitType}
118118
*/
119119
@XmlElement
120-
public void setChangingRateUnitType(ChangingRateUnitType changingRateUnitType) {
121-
this.changingRateUnitType = changingRateUnitType;
120+
public void setChargingRateUnit(ChargingRateUnitType chargingRateUnit) {
121+
this.chargingRateUnit = chargingRateUnit;
122122
}
123123

124124
@Override
@@ -136,15 +136,15 @@ public boolean transactionRelated() {
136136

137137
@Override
138138
public int hashCode() {
139-
return Objects.hash(connectorId, duration, changingRateUnitType);
139+
return Objects.hash(connectorId, duration, chargingRateUnit);
140140
}
141141

142142
@Override
143143
public String toString() {
144144
return MoreObjects.toStringHelper(this)
145145
.add("connectorId", connectorId)
146146
.add("duration", duration)
147-
.add("changingRateUnitType", changingRateUnitType)
147+
.add("chargingRateUnit", chargingRateUnit)
148148
.add("isValid", validate())
149149
.toString();
150150
}

ocpp-v1_6/src/test/java/eu/chargetime/ocpp/model/test/GetCompositeScheduleRequestTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import static org.junit.Assert.assertThat;
55

66
import eu.chargetime.ocpp.PropertyConstraintException;
7-
import eu.chargetime.ocpp.model.smartcharging.ChangingRateUnitType;
7+
import eu.chargetime.ocpp.model.smartcharging.ChargingRateUnitType;
88
import eu.chargetime.ocpp.model.smartcharging.GetCompositeScheduleRequest;
99
import org.junit.Before;
1010
import org.junit.Rule;
@@ -87,15 +87,15 @@ public void setDuration_zeroInteger_durationIsSet() {
8787
}
8888

8989
@Test
90-
public void setChangingRateUnitType_A_changingRateUnitTypeIsSet() {
90+
public void setChargingRateUnitType_A_chargingRateUnitTypeIsSet() {
9191
// Given
92-
ChangingRateUnitType chargingRateUnitType = ChangingRateUnitType.A;
92+
ChargingRateUnitType chargingRateUnit = ChargingRateUnitType.A;
9393

9494
// When
95-
request.setChangingRateUnitType(chargingRateUnitType);
95+
request.setChargingRateUnit(chargingRateUnit);
9696

9797
// Then
98-
assertThat(request.getChangingRateUnitType(), equalTo(chargingRateUnitType));
98+
assertThat(request.getChargingRateUnit(), equalTo(chargingRateUnit));
9999
}
100100

101101
@Test
@@ -112,7 +112,7 @@ public void validate_connectorIdAndMeterValueIsValid_returnTrue() {
112112
// Given
113113
request.setConnectorId(42);
114114
request.setDuration(0);
115-
request.setChangingRateUnitType(ChangingRateUnitType.A);
115+
request.setChargingRateUnit(ChargingRateUnitType.A);
116116

117117
// When
118118
boolean isValid = request.validate();

0 commit comments

Comments
 (0)