[eslint] enable array-bracket-spacing

Author: ljharb

.eslintrc

@@ -19,6 +19,7 @@
         "ecmaVersion": 2020,
     },
     "rules": {
+        "array-bracket-spacing": [2, "never"],
         "arrow-body-style": [2, "as-needed"],
         "arrow-parens": [2, "always"],
         "arrow-spacing": [2, { "before": true, "after": true }],

src/rules/extensions.js

@@ -5,7 +5,7 @@ import { isBuiltIn, isExternalModule, isScoped } from '../core/importType';
 import moduleVisitor from 'eslint-module-utils/moduleVisitor';
 import docsUrl from '../docsUrl';
 
-const enumValues = { enum: [ 'always', 'ignorePackages', 'never' ] };
+const enumValues = { enum: ['always', 'ignorePackages', 'never'] };
 const patternProperties = {
   type: 'object',
   patternProperties: { '.*': enumValues },

src/rules/no-absolute-path.js

@@ -12,7 +12,7 @@ module.exports = {
       url: docsUrl('no-absolute-path'),
     },
     fixable: 'code',
-    schema: [ makeOptionsSchema() ],
+    schema: [makeOptionsSchema()],
   },
 
   create(context) {

tests/src/core/hash.js

@@ -29,7 +29,7 @@ describe('hash', function () {
     });
 
     it('handles Array instances', function () {
-      expectHash(hashify([ 'a string' ]), '["a string",]');
+      expectHash(hashify(['a string']), '["a string",]');
     });
 
     it('handles empty Array instances', function () {
@@ -45,13 +45,13 @@ describe('hash', function () {
     });
 
     it('handles nested Object and Array instances', function () {
-      expectHash(hashify({ foo: 123.456, 'a key': 'a value', obj: { arr: [ { def: 'ghi' } ] } }), '{"a key":"a value","foo":123.456,"obj":{"arr":[{"def":"ghi",},],},}');
+      expectHash(hashify({ foo: 123.456, 'a key': 'a value', obj: { arr: [{ def: 'ghi' }] } }), '{"a key":"a value","foo":123.456,"obj":{"arr":[{"def":"ghi",},],},}');
     });
   });
 
   describe('hashArray', function () {
     it('handles Array instances', function () {
-      expectHash(hashArray([ 'a string' ]), '["a string",]');
+      expectHash(hashArray(['a string']), '["a string",]');
     });
 
     it('handles empty Array instances', function () {
@@ -69,7 +69,7 @@ describe('hash', function () {
     });
 
     it('handles nested Object and Array instances', function () {
-      expectHash(hashObject({ foo: 123.456, 'a key': 'a value', obj: { arr: [ { def: 'ghi' } ] } }), '{"a key":"a value","foo":123.456,"obj":{"arr":[{"def":"ghi",},],},}');
+      expectHash(hashObject({ foo: 123.456, 'a key': 'a value', obj: { arr: [{ def: 'ghi' }] } }), '{"a key":"a value","foo":123.456,"obj":{"arr":[{"def":"ghi",},],},}');
     });
   });
 

tests/src/core/ignore.js

@@ -19,7 +19,7 @@ describe('ignore', function () {
     });
 
     it('ignores paths with invalid extensions when configured with import/extensions', function () {
-      const testContext = utils.testContext({ 'import/extensions': [ '.js', '.jsx', '.ts' ] });
+      const testContext = utils.testContext({ 'import/extensions': ['.js', '.jsx', '.ts'] });
 
       expect(isIgnored('../files/foo.js', testContext)).to.equal(false);
 
@@ -45,7 +45,7 @@ describe('ignore', function () {
     });
 
     it('can be configured with import/extensions', function () {
-      const testContext = utils.testContext({ 'import/extensions': [ '.foo', '.bar' ] });
+      const testContext = utils.testContext({ 'import/extensions': ['.foo', '.bar'] });
 
       expect(hasValidExtension('../files/foo.foo', testContext)).to.equal(true);
 

tests/src/core/parse.js

@@ -76,7 +76,7 @@ describe('parse(content, { settings, ecmaFeatures })', function () {
     const parseSpy = sinon.spy();
     const parserOptions = { ecmaFeatures: { jsx: true } };
     parseStubParser.parse = parseSpy;
-    expect(parse.bind(null, path, content, { settings: { 'import/parsers': { [parseStubParserPath]: [ '.js' ] } }, parserPath: null, parserOptions })).not.to.throw(Error);
+    expect(parse.bind(null, path, content, { settings: { 'import/parsers': { [parseStubParserPath]: ['.js'] } }, parserPath: null, parserOptions })).not.to.throw(Error);
     expect(parseSpy.callCount, 'custom parser to be called once').to.equal(1);
   });
 
@@ -123,7 +123,7 @@ describe('parse(content, { settings, ecmaFeatures })', function () {
   it('prefers parsers specified in the settings over languageOptions.parser', () => {
     const parseSpy = sinon.spy();
     parseStubParser.parse = parseSpy;
-    expect(parse.bind(null, path, content, { settings: { 'import/parsers': { [parseStubParserPath]: [ '.js' ] } }, parserPath: null, languageOptions: { parser: { parse() {} } } })).not.to.throw(Error);
+    expect(parse.bind(null, path, content, { settings: { 'import/parsers': { [parseStubParserPath]: ['.js'] } }, parserPath: null, languageOptions: { parser: { parse() {} } } })).not.to.throw(Error);
     expect(parseSpy.callCount, 'custom parser to be called once').to.equal(1);
   });
 

tests/src/core/resolve.js

@@ -86,7 +86,7 @@ describe('resolve', function () {
   });
 
   it('respects import/resolver as array of strings', function () {
-    const testContext = utils.testContext({ 'import/resolver': [ './foo-bar-resolver-v2', './foo-bar-resolver-v1' ] });
+    const testContext = utils.testContext({ 'import/resolver': ['./foo-bar-resolver-v2', './foo-bar-resolver-v1'] });
 
     expect(resolve(
       '../files/foo',
@@ -104,7 +104,7 @@ describe('resolve', function () {
   });
 
   it('respects import/resolver as array of objects', function () {
-    const testContext = utils.testContext({ 'import/resolver': [ { './foo-bar-resolver-v2': {} }, { './foo-bar-resolver-v1': {} } ] });
+    const testContext = utils.testContext({ 'import/resolver': [{ './foo-bar-resolver-v2': {} }, { './foo-bar-resolver-v1': {} }] });
 
     expect(resolve(
       '../files/foo',
@@ -254,7 +254,7 @@ describe('resolve', function () {
     });
 
     it('respects import/resolver as array of strings', function () {
-      const testContext = utils.testContext({ 'import/resolver': [ './foo-bar-resolver-v2', './foo-bar-resolver-v1' ] });
+      const testContext = utils.testContext({ 'import/resolver': ['./foo-bar-resolver-v2', './foo-bar-resolver-v1'] });
 
       expect(resolve(
         '../files/foo',
@@ -272,7 +272,7 @@ describe('resolve', function () {
     });
 
     it('respects import/resolver as array of objects', function () {
-      const testContext = utils.testContext({ 'import/resolver': [ { './foo-bar-resolver-v2': {} }, { './foo-bar-resolver-v1': {} } ] });
+      const testContext = utils.testContext({ 'import/resolver': [{ './foo-bar-resolver-v2': {} }, { './foo-bar-resolver-v1': {} }] });
 
       expect(resolve(
         '../files/foo',
@@ -386,7 +386,7 @@ describe('resolve', function () {
       'import/cache': { lifetime: 1 },
     });
 
-    const infiniteContexts = [ '∞', 'Infinity' ].map((inf) => [inf,
+    const infiniteContexts = ['∞', 'Infinity'].map((inf) => [inf,
       utils.testContext({
         'import/cache': { lifetime: inf },
       })]);