fix: include options hash in cache key for options normalization (#466)

Author: anomiex

.changeset/slick-breads-feel.md

@@ -0,0 +1,5 @@
+---
+"eslint-import-resolver-typescript": patch
+---
+
+fix: include options hash in cache key for options normalization

src/normalize-options.ts

@@ -1,3 +1,4 @@
+import { stableHash } from 'stable-hash-x'
 import { globSync, isDynamicPattern } from 'tinyglobby'
 import type { TsconfigOptions } from 'unrs-resolver'
 
@@ -76,10 +77,12 @@ export function normalizeOptions(
     ensured = true
   }
 
+  const optionsHash = stableHash(options)
+  const cacheKey = `${configFile}\0${optionsHash}`
   if (configFile) {
-    const cachedOptions = configFileMapping.get(configFile)
+    const cachedOptions = configFileMapping.get(cacheKey)
     if (cachedOptions) {
-      log('using cached options for', configFile)
+      log('using cached options for', configFile, 'with options', options)
       return cachedOptions
     }
   }
@@ -101,7 +104,7 @@ export function normalizeOptions(
   }
 
   if (configFile) {
-    configFileMapping.set(configFile, options)
+    configFileMapping.set(cacheKey, options)
   }
 
   return options

tests/e2e/__snapshots__/e2e.spec.ts.snap

@@ -32,6 +32,14 @@ exports[`e2e cases > should exec eslint successfully > dotProject 1`] = `
 }
 `;
 
+exports[`e2e cases > should exec eslint successfully > filesWithDifferentOptions 1`] = `
+{
+  "exitCode": 0,
+  "stderr": "",
+  "stdout": "",
+}
+`;
+
 exports[`e2e cases > should exec eslint successfully > importXResolverV3 1`] = `
 {
   "exitCode": 0,

tests/e2e/filesWithDifferentOptions/eslint.config.js

@@ -0,0 +1,44 @@
+import { defineConfig, globalIgnores } from 'eslint/config'
+import { defaultExtensions } from 'eslint-import-resolver-typescript'
+import importX, { flatConfigs } from 'eslint-plugin-import-x'
+
+export default defineConfig(
+  globalIgnores(['eslint.config.js']),
+  {
+    files: ['**/*.foo.js', '**/*.bar.js'],
+    plugins: {
+      'import-x': importX,
+    },
+    settings: {
+      ...flatConfigs.typescript.settings,
+      'import-x/resolver': {
+        typescript: {},
+      },
+    },
+    rules: {
+      'import-x/no-unresolved': 'error',
+    },
+  },
+  // .foo.js files should prefer importing other .foo.js files.
+  {
+    files: ['**/*.foo.js'],
+    settings: {
+      'import-x/resolver': {
+        typescript: {
+          extensions: ['.foo.js', ...defaultExtensions],
+        },
+      },
+    },
+  },
+  // .bar.js files should prefer importing other .bar.js files.
+  {
+    files: ['**/*.bar.js'],
+    settings: {
+      'import-x/resolver': {
+        typescript: {
+          extensions: ['.bar.js', ...defaultExtensions],
+        },
+      },
+    },
+  },
+)

tests/e2e/filesWithDifferentOptions/src/a.bar.js

@@ -0,0 +1 @@
+import y from './y'

tests/e2e/filesWithDifferentOptions/src/a.foo.js

@@ -0,0 +1 @@
+import x from './x'

tests/e2e/filesWithDifferentOptions/src/x.foo.js

@@ -0,0 +1 @@
+export const x = 'x'

tests/e2e/filesWithDifferentOptions/src/y.bar.js

@@ -0,0 +1 @@
+export const y = 'y'

tests/e2e/filesWithDifferentOptions/tsconfig.json

@@ -0,0 +1 @@
+{}