chore: stricter lint rules for tests

test codes should also be considered as source codes

Author: JounQin

.eslintignore

@@ -1 +1,2 @@
 lib
+CHANGELOG.md

.eslintrc.js

@@ -1,9 +1,9 @@
-const { md, mdx } = require('@1stg/eslint-config/overrides')
+const { js, md, mdx } = require('@1stg/eslint-config/overrides')
 
 module.exports = {
-  extends: ['plugin:prettier/recommended'],
-  overrides: [md, mdx],
+  extends: ['@1stg'],
+  overrides: [js, md, mdx],
   rules: {
-    'prettier/prettier': 2,
+    'node/no-unsupported-features/es-syntax': 0,
   },
 }

.gitignore

@@ -1,3 +1,4 @@
+.type-coverage
 lib
 node_modules
 *.log

.lintstagedrc

@@ -0,0 +1 @@
+module.exports = require('@1stg/lint-staged')

.lintstagedrc.js

@@ -5,5 +5,6 @@ checks:
         - path: 'lib/**/*.*'
   - name: type-coverage-watcher
     options:
+      atLeast: 100
       ignoreCatch: true
       strict: true

codechecks.yml

@@ -18,11 +18,9 @@
   ],
   "scripts": {
     "build": "rimraf lib && tsc -b src && r",
-    "lint:md": "cross-env EFF_NO_LINK_RULES=true eslint . --ext md -f friendly",
-    "lint:src": "cross-env EFF_NO_LINK_RULES=true eslint src --ext js,ts -f friendly",
-    "lint": "run-p lint:*",
+    "lint": "cross-env EFF_NO_LINK_RULES=true eslint . --ext md,js,ts -f friendly --ignore-pattern tests",
     "pretest": "r",
-    "test": "eslint tests/**/index.ts",
+    "test": "cross-env EFF_NO_LINK_RULES=true eslint tests/**/*.{ts,tsx} -f friendly",
     "type-coverage": "type-coverage --cache --ignore-catch --detail --strict"
   },
   "keywords": [
@@ -47,6 +45,7 @@
     "@1stg/babel-preset": "^0.6.1",
     "@1stg/eslint-config": "^0.9.3",
     "@1stg/husky-config": "^0.3.0",
+    "@1stg/lint-staged": "^0.6.0",
     "@1stg/prettier-config": "^0.2.0",
     "@1stg/remark-config": "^0.2.1",
     "@1stg/rollup-config": "^0.9.3",
@@ -56,7 +55,7 @@
     "@commitlint/config-conventional": "^8.1.0",
     "@types/debug": "^4.1.5",
     "@types/glob": "^7.1.1",
-    "@types/node": "^12.7.4",
+    "@types/node": "^12.7.5",
     "@types/resolve": "^0.0.8",
     "@types/unist": "^2.0.3",
     "cross-env": "^5.2.1",

package.json

@@ -1,18 +1,27 @@
 const path = require('path')
 
 module.exports = dirname => ({
-  env: {
-    es6: true,
-  },
-  parserOptions: {
-    ecmaVersion: 2018,
-    sourceType: 'module',
+  parser: '@typescript-eslint/parser',
+  extends: [
+    'eslint:recommended',
+    'plugin:@typescript-eslint/eslint-recommended',
+    'plugin:@typescript-eslint/recommended',
+    'plugin:import/errors',
+    'plugin:import/typescript',
+  ],
+  settings: {
+    'import/resolver': {
+      [path.resolve(__dirname, '../lib/cjs.js')]: {
+        directory: dirname,
+        alwaysTryTypes: true,
+      },
+    },
   },
-  plugins: ['import'],
   rules: {
-    'import/no-unresolved': 'error',
+    'import/no-duplicates': 0,
+    'import/no-unresolved': 2,
     'import/extensions': [
-      'error',
+      2,
       'ignorePackages',
       {
         js: 'never',
@@ -21,13 +30,7 @@ module.exports = dirname => ({
         tsx: 'never',
       },
     ],
-  },
-  settings: {
-    'import/resolver': {
-      [path.resolve(__dirname, '../lib/cjs.js')]: {
-        directory: dirname,
-        alwaysTryTypes: true,
-      },
-    },
+    'node/no-extraneous-import': 0,
+    'node/no-missing-import': 0,
   },
 })

tests/baseEslintConfig.js

@@ -48,6 +48,11 @@
   resolved "https://registry.yarnpkg.com/@1stg/husky-config/-/husky-config-0.3.0.tgz#dcf89d1f791dfd04d8d1a3fc1b59ba97c57ed6be"
   integrity sha512-YKVLG5lc/qKPyY9by/mVPdZLMe3s1FuO1d0mCmCogYl6VTWW/98LW80B4pMcDTmHPBTjZfKUAwgVBIvaYVthBA==
 
+"@1stg/lint-staged@^0.6.0":
+  version "0.6.0"
+  resolved "https://registry.yarnpkg.com/@1stg/lint-staged/-/lint-staged-0.6.0.tgz#cdb0bca89e3815f1dfe28a9282b882d50b6bb241"
+  integrity sha512-NedCH9PEjEVy0R/FH0LoviWJP/aX2a0MDiDFqv+Jv68MqCeXWFFT9suY3NcZTjEf034Ofn9+dJ+9Z80qujFHyA==
+
 "@1stg/prettier-config@^0.2.0":
   version "0.2.0"
   resolved "https://registry.yarnpkg.com/@1stg/prettier-config/-/prettier-config-0.2.0.tgz#853c1142834f31d9287cd9e30f2b91d46e4961d6"
@@ -1412,6 +1417,11 @@
   resolved "https://registry.yarnpkg.com/@types/node/-/node-12.7.4.tgz#64db61e0359eb5a8d99b55e05c729f130a678b04"
   integrity sha512-W0+n1Y+gK/8G2P/piTkBBN38Qc5Q1ZSO6B5H3QmPCUewaiXOo2GCAWZ4ElZCcNhjJuBSUSLGFUJnmlCn5+nxOQ==
 
+"@types/node@^12.7.5":
+  version "12.7.5"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-12.7.5.tgz#e19436e7f8e9b4601005d73673b6dc4784ffcc2f"
+  integrity sha512-9fq4jZVhPNW8r+UYKnxF1e2HkDWOWKM5bC2/7c9wPV835I0aOrVbS/Hw/pWPk2uKrNXQqg9Z959Kz+IYDd5p3w==
+
 "@types/normalize-package-data@^2.4.0":
   version "2.4.0"
   resolved "https://registry.yarnpkg.com/@types/normalize-package-data/-/normalize-package-data-2.4.0.tgz#e486d0d97396d79beedd0a6e33f4534ff6b4973e"