Fix FREE emission for consts

iluuu1994 · iluuu1994 · commit b3a15ecbc152 · 2023-10-19T15:46:28.000+02:00
diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c
@@ -6216,7 +6216,7 @@ static void zend_compile_is(znode *result, zend_ast *ast)
 	ZVAL_COPY(&pattern_node.u.constant, &pattern_zv);
 
 	zend_emit_op_tmp(result, ZEND_IS, &expr_node, &pattern_node);
-	if (expr_node.op_type != IS_CV) {
+	if (expr_node.op_type & (IS_VAR|IS_TMP_VAR)) {
 		// FIXME: Verify live ranges recognizes that OP1 needs to be freed if an exception occurs
 		zend_emit_op(NULL, ZEND_FREE, &expr_node, NULL);
 	}

Original file line number	Diff line number	Diff line change
`@@ -6216,7 +6216,7 @@ static void zend_compile_is(znode result, zend_ast ast)`
`6216`	`6216`	`ZVAL_COPY(&pattern_node.u.constant, &pattern_zv);`
`6217`	`6217`
`6218`	`6218`	`zend_emit_op_tmp(result, ZEND_IS, &expr_node, &pattern_node);`
`6219`		`- if (expr_node.op_type != IS_CV) {`
	`6219`	`+ if (expr_node.op_type & (IS_VAR\|IS_TMP_VAR)) {`
`6220`	`6220`	`// FIXME: Verify live ranges recognizes that OP1 needs to be freed if an exception occurs`
`6221`	`6221`	`zend_emit_op(NULL, ZEND_FREE, &expr_node, NULL);`
`6222`	`6222`	`}`