Add comment

ndossche · ndossche · commit a2b820488015 · 2025-01-09T19:52:13.000+01:00
Closes phpGH-17274.
diff --git a/Zend/zend_ini.c b/Zend/zend_ini.c
@@ -701,6 +701,7 @@ static zend_ulong zend_ini_parse_quantity_internal(zend_string *value, zend_ini_
 				return 0;
         }
         digits += 2;
+		/* STRTOULL may silently ignore a prefix of whitespace, sign, and base prefix, which would be invalid at this position */
 		if (UNEXPECTED(digits == str_end || digits != zend_ini_consume_quantity_prefix(digits, str_end, base))) {
 			/* Escape the string to avoid null bytes and to make non-printable chars
 			 * visible */

Original file line number	Diff line number	Diff line change
`@@ -701,6 +701,7 @@ static zend_ulong zend_ini_parse_quantity_internal(zend_string *value, zend_ini_`
`701`	`701`	`return 0;`
`702`	`702`	`}`
`703`	`703`	`digits += 2;`
	`704`	`+ /* STRTOULL may silently ignore a prefix of whitespace, sign, and base prefix, which would be invalid at this position */`
`704`	`705`	`if (UNEXPECTED(digits == str_end \|\| digits != zend_ini_consume_quantity_prefix(digits, str_end, base))) {`
`705`	`706`	`/* Escape the string to avoid null bytes and to make non-printable chars`
`706`	`707`	`* visible */`