Add class constants for required arguments for view operations

Author: lornajane

src/PHPCouchDB/Database.php

@@ -19,6 +19,8 @@ class Database
 
     const OPTION_INCLUDE_DOCS = 'include_docs';
     const OPTION_REDUCE = 'reduce';
+    const OPTION_DDOC = 'ddoc';
+    const OPTION_VIEW = 'view';
 
     /**
      * Constructor for the Database object - this is usually called by
@@ -179,25 +181,25 @@ public function getDocById($id) : Document
     public function getView($options = []) : array
     {
         // check we have ddoc and view name
-        if (!isset($options['ddoc'])) {
+        if (!isset($options[self::OPTION_DDOC])) {
             throw new Exception\ServerException(
                 'ddoc is a required parameter for getView'
             );
         }
-        if (!isset($options['view'])) {
+        if (!isset($options[self::OPTION_VIEW])) {
             throw new Exception\ServerException(
                 'view is a required parameter for getView'
             );
         }
 
-        $endpoint = "/" . $this->db_name . "/_design/" . $options['ddoc']
-            . "/_view/" . $options['view'];
+        $endpoint = "/" . $this->db_name . "/_design/" . $options[self::OPTION_DDOC]
+            . "/_view/" . $options[self::OPTION_VIEW];
 
         // grab extra params
         $query = [];
         foreach ($options as $key => $value) {
             // skip the values we need for the URL, pass the rest through
-            if (!in_array($key, ["ddoc", "view"])) {
+            if (!in_array($key, [self::OPTION_DDOC, self::OPTION_VIEW])) {
                 $query[$key] = $value;
             }
         }

tests/PHPCouchDB/DatabaseTest.php

@@ -180,7 +180,11 @@ public function testView() {
 		// userland code starts
         $server = new \PHPCouchDB\Server([\PHPCouchDB\Server::OPTION_CLIENT => $client]);
         $database = $server->useDB([\PHPCouchDB\Server::OPTION_NAME => "egdb"]);
-        $docs = $database->getView(["ddoc" => "myview", "view" => "year", "group" => true]);
+        $docs = $database->getView([
+            \PHPCouchDB\Database::OPTION_DDOC => "myview",
+            \PHPCouchDB\Database::OPTION_VIEW => "year",
+            "group" => true
+        ]);
 
         $this->assertInternalType('array', $docs);
         $this->assertEquals(3, count($docs));
@@ -203,7 +207,13 @@ public function testViewWithIncludeDocs() {
 		// userland code starts
         $server = new \PHPCouchDB\Server([\PHPCouchDB\Server::OPTION_CLIENT => $client]);
         $database = $server->useDB([\PHPCouchDB\Server::OPTION_NAME => "egdb"]);
-        $docs = $database->getView(["ddoc" => "myview", "view" => "year", "reduce" => false, "limit" => 3, "include_docs" => true]);
+        $docs = $database->getView([
+            \PHPCouchDB\Database::OPTION_DDOC => "myview",
+            \PHPCouchDB\Database::OPTION_VIEW => "year",
+            "reduce" => false,
+            "limit" => 3,
+            \PHPCouchDB\Database::OPTION_INCLUDE_DOCS => true
+        ]);
 
         $this->assertInternalType('array', $docs);
         $this->assertEquals(3, count($docs));