Skip to content

Commit 2f57609

Browse files
authored
Chore/improve-db-connectivity (#142)
* adding .env.local to gitignore, implementing better db connectivity service with better architecture * updating prisma imports * removing driver specifications * formatting * fixing tests
1 parent ee09503 commit 2f57609

File tree

89 files changed

+2047
-307
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

89 files changed

+2047
-307
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,9 @@ dev.env
6565
dev.op.env
6666
.env.merged
6767
.env.op.local
68+
.env*.local
69+
# mock that shouldnt change
70+
*/mock.jwt.cookie.auth.guard.ts
6871

6972
# manifest files
7073
face_expresstion_model-weights_manifest.json

.secrets.baseline

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,15 @@
209209
"verified_result": null
210210
}
211211
],
212+
"apps/api/src/database/prisma.service.spec.ts": [
213+
{
214+
"hashed_secret": "9d4e1e23bd5b727046a9e3b4b7db57bd8d6ee684",
215+
"is_verified": false,
216+
"line_number": 8,
217+
"type": "Basic Auth Credentials",
218+
"verified_result": null
219+
}
220+
],
212221
"apps/web/.env.template": [
213222
{
214223
"hashed_secret": "d08f88df745fa7950b104e4a707a31cfce7b5841",

apps/api-gateway/src/auth/jwt/cookie-based/mock.jwt.cookie.auth.guard.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,15 @@ export class MockJwtCookieAuthGuard extends AuthGuard("cookie-strategy") {
2222
const request: RequestWithUserSession = context.switchToHttp().getRequest();
2323

2424
request.user = {
25-
userId: "magdy.hafez@ibm.com1",
26-
role: UserRole.AUTHOR,
27-
groupId: "autogen-faculty-v1-course-v1-IND-AI0103EN-v1",
28-
assignmentId: 1,
25+
userId: "dev-user",
26+
role: UserRole.LEARNER,
27+
groupId: "string",
28+
assignmentId: 1888,
2929
gradingCallbackRequired: false,
3030
returnUrl: "https://skills.network",
3131
launch_presentation_locale: "en",
3232
};
33+
3334
return true;
3435
}
3536
}

apps/api/src/api/Job/job-status.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { Injectable } from "@nestjs/common";
22
import { Job } from "@prisma/client";
33
import { Observable, Subject } from "rxjs";
4-
import { PrismaService } from "src/prisma.service";
4+
import { PrismaService } from "src/database/prisma.service";
55

66
@Injectable()
77
export class JobStatusServiceV1 {

apps/api/src/api/Job/job.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { HttpModule } from "@nestjs/axios";
22
import { Module } from "@nestjs/common";
3-
import { PrismaService } from "src/prisma.service";
3+
import { PrismaService } from "src/database/prisma.service";
44
import { JobStatusServiceV1 } from "./job-status.service";
55

66
@Module({

apps/api/src/api/admin/admin.controller.spec.ts

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,27 @@
11
import { Test, TestingModule } from "@nestjs/testing";
22
import { AdminVerificationService } from "../../auth/services/admin-verification.service";
3-
import { PrismaService } from "../../prisma.service";
3+
import { PrismaService } from "../../database/prisma.service";
44
import { LLM_PRICING_SERVICE } from "../llm/llm.constants";
55
import { AdminController } from "./admin.controller";
66
import { AdminRepository } from "./admin.repository";
77
import { AdminService } from "./admin.service";
88

99
describe("AdminController", () => {
1010
let controller: AdminController;
11+
const originalDatabaseUrl = process.env.DATABASE_URL;
12+
13+
beforeAll(() => {
14+
process.env.DATABASE_URL =
15+
originalDatabaseUrl ?? "postgresql://user:pass@localhost:5432/test"; // pragma: allowlist secret
16+
});
17+
18+
afterAll(() => {
19+
if (originalDatabaseUrl) {
20+
process.env.DATABASE_URL = originalDatabaseUrl;
21+
} else {
22+
delete process.env.DATABASE_URL;
23+
}
24+
});
1125

1226
beforeEach(async () => {
1327
const mockLlmPricingService = {

apps/api/src/api/admin/admin.module.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Module } from "@nestjs/common";
22
import { PassportModule } from "@nestjs/passport";
3-
import { PrismaService } from "src/prisma.service";
3+
import { PrismaService } from "src/database/prisma.service";
44
import { AdminAuthModule } from "../../auth/admin-auth.module";
55
import { AuthModule } from "../../auth/auth.module";
66
import { LlmModule } from "../llm/llm.module";

apps/api/src/api/admin/admin.repository.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Injectable } from "@nestjs/common";
22
import { Assignment, AssignmentAttempt } from "@prisma/client";
3-
import { PrismaService } from "src/prisma.service";
3+
import { PrismaService } from "src/database/prisma.service";
44
import { RegradingRequestDto } from "../assignment/attempt/dto/assignment-attempt/feedback.request.dto";
55

66
@Injectable()

apps/api/src/api/admin/admin.service.spec.ts

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,24 @@
11
import { Test, TestingModule } from "@nestjs/testing";
2-
import { PrismaService } from "../../prisma.service";
2+
import { PrismaService } from "../../database/prisma.service";
33
import { LLM_PRICING_SERVICE } from "../llm/llm.constants";
44
import { AdminService } from "./admin.service";
55

66
describe("AdminService", () => {
77
let service: AdminService;
8+
const originalDatabaseUrl = process.env.DATABASE_URL;
9+
10+
beforeAll(() => {
11+
process.env.DATABASE_URL =
12+
originalDatabaseUrl ?? "postgresql://user:pass@localhost:5432/test"; // pragma: allowlist secret
13+
});
14+
15+
afterAll(() => {
16+
if (originalDatabaseUrl) {
17+
process.env.DATABASE_URL = originalDatabaseUrl;
18+
} else {
19+
delete process.env.DATABASE_URL;
20+
}
21+
});
822

923
beforeEach(async () => {
1024
const mockLlmPricingService = {

apps/api/src/api/admin/admin.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
UserRole,
1010
UserSession,
1111
} from "../../auth/interfaces/user.session.interface";
12-
import { PrismaService } from "../../prisma.service";
12+
import { PrismaService } from "../../database/prisma.service";
1313
import { LLMPricingService } from "../llm/core/services/llm-pricing.service";
1414
import { LLM_PRICING_SERVICE } from "../llm/llm.constants";
1515
import { AdminAddAssignmentToGroupResponseDto } from "./dto/assignment/add.assignment.to.group.response.dto";

0 commit comments

Comments
 (0)