Skip to content

bug: BigQuery compiler FirstValue and LastValue not implemented correctly. #11726

@jhurst22

Description

@jhurst22

What happened?

A simple bug; BQ compiler does not seem to have implemented visit_FirstValue or visit_LastValue to correctly handle what in sqlglot should be translated into IgnoreNulls(FirstValue(...)). BQ compiler uses the base compilation, which seems to ignore include_nulls flag when compiled to BQ, since it does not respect the compilation BQ needs.

Could we add a simple visit_FirstValue in BQ to resolve this?

What version of ibis are you using?

10.7.0

What backend(s) are you using, if any?

BigQuery

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIncorrect behavior inside of ibis

    Type

    No type

    Projects

    Status

    backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions