[Tests] Improved quality of LegacyDFSClusterTest

Author: alongosz

tests/bundle/IO/DependencyInjection/ConfigurationFactory/MetadataHandler/LegacyDFSClusterTest.php

@@ -4,37 +4,35 @@
  * @copyright Copyright (C) Ibexa AS. All rights reserved.
  * @license For full copyright and license information view LICENSE file distributed with this source code.
  */
+declare(strict_types=1);
 
 namespace Ibexa\Tests\Bundle\IO\DependencyInjection\ConfigurationFactory\MetadataHandler;
 
-use Ibexa\Bundle\IO\DependencyInjection\ConfigurationFactory\MetadataHandler\LegacyDFSCluster;
+use Ibexa\Bundle\IO\DependencyInjection\ConfigurationFactory;
+use Ibexa\Bundle\IO\DependencyInjection\ConfigurationFactory\MetadataHandler\LegacyDFSCluster as LegacyDFSClusterConfigurationFactory;
+use Ibexa\Core\IO\IOMetadataHandler\LegacyDFSCluster;
 use Ibexa\Tests\Bundle\IO\DependencyInjection\ConfigurationFactoryTestCase;
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Reference;
 
 final class LegacyDFSClusterTest extends ConfigurationFactoryTestCase
 {
-    /**
-     * Returns an instance of the tested factory.
-     *
-     * @return \Ibexa\Bundle\IO\DependencyInjection\ConfigurationFactory
-     */
-    public function provideTestedFactory()
+    public function provideTestedFactory(): ConfigurationFactory
     {
-        return new LegacyDFSCluster();
+        return new LegacyDFSClusterConfigurationFactory();
     }
 
     public function provideExpectedParentServiceId(): string
     {
-        return \Ibexa\Core\IO\IOMetadataHandler\LegacyDFSCluster::class;
+        return LegacyDFSCluster::class;
     }
 
-    public function provideParentServiceDefinition()
+    public function provideParentServiceDefinition(): Definition
     {
         return new Definition(null, [null]);
     }
 
-    public function provideHandlerConfiguration()
+    public function provideHandlerConfiguration(): array
     {
         return ['connection' => 'doctrine.dbal.test_connection'];
     }
@@ -46,9 +44,9 @@ public function provideHandlerConfiguration()
      *
      * @param string $handlerServiceId id of the service that was registered by the compiler pass
      */
-    public function validateConfiguredHandler($handlerServiceId)
+    public function validateConfiguredHandler(string $handlerServiceId): void
     {
-        self::assertContainerBuilderHasServiceDefinitionWithArgument(
+        $this->assertContainerBuilderHasServiceDefinitionWithArgument(
             $handlerServiceId,
             0,
             new Reference('doctrine.dbal.test_connection')