Fix broken test function parameter order #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected parameter order in test_read() function call to match
open_data() signature.
Before: open_data((2018, 2018), 'rain', 'yearwise', cwd)
After: open_data('rain', 2018, 2018, 'yearwise', cwd)
Correct signature: open_data(var_type, start_yr, end_yr, fn_format, file_dir)
Also fixed spacing in assert statement for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect parameter order in
test_read()function.Problem
The test was calling
open_data()with wrong parameter order:Function signature is:
The test was passing a tuple as
var_typeand strings as years, which would cause the test to fail.Solution
Corrected parameter order:
Changes
test/test.pyopen_data()call