Adding support for Definition from dictionary

Author: Jason Costello

hypervector/resources/core/definition.py

@@ -45,10 +45,16 @@ def list(cls):
         return [cls.from_response(definition) for definition in response]
 
     @classmethod
-    def new(cls, definition_file, project_uuid=None):
+    def new(cls, definition, project_uuid=None):
         endpoint = f"{hypervector.API_BASE}/{cls.resource_name}/add"
+
+        if isinstance(definition, dict):
+            definition_json = definition
+        else:
+            definition_json = _parse_definition_from_json_file(definition)
+
         data = {
-            "definition": _parse_definition_from_json_file(definition_file),
+            "definition": definition_json,
             "project_uuid": project_uuid
         }
         response = requests.post(endpoint, json=data, headers=cls.get_headers()).json()

tests/test_definition_api_resource.py

@@ -26,11 +26,36 @@ def test_definition_list(mocked_resources, mocked_responses):
         assert retrieved_definition.definition_uuid == definition.definition_uuid
 
 
-def test_definition_new(mocked_resources):
+def test_definition_new_from_dict(mocked_resources):
+    project, _, _, _ = mocked_resources
+
+    definition_dict = {
+        "definition_name": "Test definition",
+        "features": [
+            {
+                "type": "float",
+                "distribution": {
+                    "type": "gaussian",
+                    "mu": 1E-2,
+                    "sigma": 1.5
+                }
+            }
+        ]
+    }
+
+    definition = hypervector.Definition.new(
+        definition=definition_dict,
+        project_uuid=project.project_uuid
+    )
+
+    assert isinstance(definition, hypervector.Definition)
+
+
+def test_definition_new_from_file(mocked_resources):
     project, _, _, _ = mocked_resources
 
     definition = hypervector.Definition.new(
-        definition_file=get_resource_path("hyperdef.json"),
+        definition=get_resource_path("hyperdef.json"),
         project_uuid=project.project_uuid
     )
 

tests/util.py

@@ -43,7 +43,7 @@ def mocked_resources(mocked_responses):
     )
 
     definition = hypervector.Definition.new(
-        definition_file=get_resource_path("hyperdef.json"),
+        definition=get_resource_path("hyperdef.json"),
         project_uuid=str(uuid.uuid4())
     )