Bug fix regex should match _

kamaleshnneerasa · kamaleshnneerasa · commit 913331dabfa3 · 2021-11-05T12:02:08.000+05:30
diff --git a/label-application-rule-config-service-impl/src/main/java/org/hypertrace/label/application/rule/config/service/LabelApplicationRuleValidatorImpl.java b/label-application-rule-config-service-impl/src/main/java/org/hypertrace/label/application/rule/config/service/LabelApplicationRuleValidatorImpl.java
@@ -180,7 +180,7 @@ public void validateLabelExpression(Action.DynamicLabel dynamicLabel) {
                 validKeys.add(tokenExtractionRule.getAlias());
               }
             });
-    Pattern pattern = Pattern.compile("\\{(\\\\}|[^}])*}");
+    Pattern pattern = Pattern.compile("\\$\\{(\\\\}|[^}])*}");
     Matcher matcher = pattern.matcher(labelExpression);
     int startOffset = 0;
     while (startOffset < labelExpression.length() && matcher.find(startOffset)) {

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ public void validateLabelExpression(Action.DynamicLabel dynamicLabel) {`
`180`	`180`	`validKeys.add(tokenExtractionRule.getAlias());`
`181`	`181`	`}`
`182`	`182`	`});`
`183`		`- Pattern pattern = Pattern.compile("\\{(\\\\}\|[^}])*}");`
	`183`	`+ Pattern pattern = Pattern.compile("\\$\\{(\\\\}\|[^}])*}");`
`184`	`184`	`Matcher matcher = pattern.matcher(labelExpression);`
`185`	`185`	`int startOffset = 0;`
`186`	`186`	`while (startOffset < labelExpression.length() && matcher.find(startOffset)) {`