fixes imports

Author: Daniel Del Core

community/@atlaskit__button/15.0.0/transform.ts

@@ -91,12 +91,11 @@ function changeImportFor(
     .find(j.ImportDeclaration)
     .filter(path => path.node.source.value === oldPackagePath)
     .find(j.ImportSpecifier)
-    .find(j.Identifier)
-    .filter(identifier => {
-      if (identifier.value.name === currentName) {
+    .filter(specifier => {
+      if (specifier.value.imported!.name === currentName) {
         return true;
       }
-      if (identifier.value.name === existingAlias) {
+      if (specifier.value.imported!.name === existingAlias) {
         return true;
       }
       return false;

packages/utils/src/imports.spec.ts

@@ -0,0 +1,86 @@
+import { API, FileInfo } from 'jscodeshift';
+import { applyTransform } from '@codeshift/test-utils';
+import * as importUtils from './imports';
+
+describe('imports', () => {
+  describe('insertImportSpecifier', () => {
+    it('inserts import specifier to existing import', async () => {
+      const transform = (file: FileInfo, api: API) => {
+        const j = api.jscodeshift;
+        const source = j(file.source);
+        importUtils.insertImportSpecifier(
+          j,
+          source,
+          j.importSpecifier(j.identifier('bar')),
+          'bar',
+        );
+
+        return source.toSource();
+      };
+      const result = await applyTransform(
+        transform,
+        `import { foo } from 'bar';`,
+      );
+      expect(result).toMatchInlineSnapshot(`"import { foo, bar } from 'bar';"`);
+    });
+
+    it('inserts import specifier to empty import', async () => {
+      const transform = (file: FileInfo, api: API) => {
+        const j = api.jscodeshift;
+        const source = j(file.source);
+        importUtils.insertImportSpecifier(
+          j,
+          source,
+          j.importSpecifier(j.identifier('bar')),
+          'bar',
+        );
+
+        return source.toSource();
+      };
+      const result = await applyTransform(transform, `import { } from 'bar';`);
+      expect(result).toMatchInlineSnapshot(`"import { bar } from 'bar';"`);
+    });
+
+    it('maintains a reference to importDec and is able to inserts import specifier', async () => {
+      const transform = (file: FileInfo, api: API) => {
+        const j = api.jscodeshift;
+        const source = j(file.source);
+
+        importUtils
+          .getImportDeclaration(j, source, '@foo/myModule')
+          .find(j.ImportSpecifier)
+          .filter(specifier => specifier.value.imported.name === 'bar')
+          .forEach(() => {
+            importUtils.insertImportSpecifier(
+              j,
+              source,
+              j.importSpecifier(j.identifier('foo')),
+              '@foo/myModule',
+            );
+          })
+          .remove();
+        return source.toSource();
+      };
+      const result = await applyTransform(
+        transform,
+        `import { bar } from '@foo/myModule';`,
+      );
+      expect(result).toMatchInlineSnapshot(
+        `"import { foo } from '@foo/myModule';"`,
+      );
+    });
+  });
+});
+
+// const result = applyTransform(
+//   codemod,
+//   `import { elevation as AkElevations, colors } from '@atlaskit/theme';
+
+// export const Unlinked = styled.span\`color: \${colors.N800};\`;
+
+// export const Card = styled.div\`
+//   position: absolute;
+//   \${props => (props.isElevated ? AkElevations.e300 : AkElevations.e100)};
+// \`;
+// `,
+// );

packages/utils/src/imports.ts

@@ -128,3 +128,12 @@ export function insertImportSpecifier(
 
   importDeclaration.get().value.specifiers.push(importSpecifier);
 }
+
+export function removeImportSpecifier(
+  j: core.JSCodeshift,
+  source: Collection<any>,
+  specifier: string,
+  sourcePath: string,
+) {
+  getImportSpecifier(j, source, specifier, sourcePath).remove();
+}

website/docs/api/codeshift-utils.mdx

@@ -323,7 +323,7 @@ import React, { useEffect } from 'react';
 ```
 
 ```js
-import { getImportSpecifier } from '@codeshift/utils';
+import { insertImportSpecifier } from '@codeshift/utils';
 
 insertImportSpecifier(j, source, 'useMemo', 'react'); // Collection containing 'useEffect'
 ```
@@ -334,6 +334,35 @@ insertImportSpecifier(j, source, 'useMemo', 'react'); // Collection containing '
 +import React, { useEffect, useMemo } from 'react';
 ```
 
+### `removeImportSpecifier`
+
+`removeImportSpecifier(j, source, specifier)`
+
+Removes an import specifier
+
+**Returns**
+
+`void`
+
+**Example**
+
+```jsx
+// src/App.js
+import React, { useEffect } from 'react';
+```
+
+```js
+import { removeImportSpecifier } from '@codeshift/utils';
+
+removeImportSpecifier(j, source, 'useMemo', 'react'); // Collection containing 'useEffect'
+```
+
+```diff
+// src/App.js
+-import React, { useEffect } from 'react';
++import React, { useEffect, useMemo } from 'react';
+```
+
 ## JSX
 
 ### `getJSXAttributes`