working for identifiers

Author: alexreardon

community/memoize-one/src/5.0.0/transform.spec.ts

@@ -45,7 +45,7 @@ describe('memoize-one@5.0.0 transform', () => {
     );
   });
 
-  it.only('should wrap inline equality arrow functions', () => {
+  it('should wrap inline equality arrow functions', () => {
     const result = applyTransform(
       transformer,
       format(`
@@ -125,15 +125,12 @@ describe('memoize-one@5.0.0 transform', () => {
     );
   });
 
-  it('should wrap references', () => {
+  it('should wrap identifiers', () => {
     const result = applyTransform(
       transformer,
       format(`
         import memoize from 'memoize-one';
-
-        function isEqual(a, b) {
-          return a === b;
-        }
+        import isEqual from 'something';
 
         function add(a: number, b: number) {
           return a + b;
@@ -146,24 +143,64 @@ describe('memoize-one@5.0.0 transform', () => {
 
     expect(result).toEqual(
       format(`
-        import memoize from "memoize-one";
+      import memoize from 'memoize-one';
+      import isEqual from 'something';
 
-        function isEqual(a, b) {
-          return a === b;
-        }
+      function add(a: number, b: number) {
+        return a + b;
+      }
 
-        function add(a: number, b: number) {
-          return a + b;
+      const memoized = memoize(add, (newArgs, lastArgs) => {
+        if (newArgs.length !== lastArgs.length) {
+          return false;
         }
 
-        const memoized = memoize(add, (newArgs, lastArgs) => {
-          if (newArgs.length !== lastArgs.length) {
-            return false;
-          }
-
-          return newArgs.every((newArg, index) => isEqual(newArg, lastArgs[index]));
-        });
+        const __equalityFn = isEqual;
+        return newArgs.every((newArg, index) => __equalityFn(newArg, lastArgs[index]));
+      });
       `),
     );
   });
+
+  // it('should wrap references', () => {
+  //   const result = applyTransform(
+  //     transformer,
+  //     format(`
+  //       import memoize from 'memoize-one';
+
+  //       function isEqual(a, b) {
+  //         return a === b;
+  //       }
+
+  //       function add(a: number, b: number) {
+  //         return a + b;
+  //       }
+
+  //       const memoized = memoize(add, isEqual);
+  //     `),
+  //     { parser: 'tsx' },
+  //   );
+
+  //   expect(result).toEqual(
+  //     format(`
+  //       import memoize from "memoize-one";
+
+  //       function isEqual(a, b) {
+  //         return a === b;
+  //       }
+
+  //       function add(a: number, b: number) {
+  //         return a + b;
+  //       }
+
+  //       const memoized = memoize(add, (newArgs, lastArgs) => {
+  //         if (newArgs.length !== lastArgs.length) {
+  //           return false;
+  //         }
+
+  //         return newArgs.every((newArg, index) => isEqual(newArg, lastArgs[index]));
+  //       });
+  //     `),
+  //   );
+  // });
 });

community/memoize-one/src/5.0.0/transform.ts

@@ -42,7 +42,8 @@ export default function transformer(
       }
       if (
         second.type === 'FunctionExpression' ||
-        second.type === 'ArrowFunctionExpression'
+        second.type === 'ArrowFunctionExpression' ||
+        second.type === 'Identifier'
       ) {
         const customEqualityFn = j.arrowFunctionExpression(
           [j.identifier('newArgs'), j.identifier('lastArgs')],
@@ -78,7 +79,7 @@ export default function transformer(
                       j.memberExpression(
                         j.identifier('lastArgs'),
                         j.identifier('index'),
-                        // computed lastArgs[index]
+                        // computed: lastArgs[index]
                         true,
                       ),
                     ]),
@@ -92,9 +93,6 @@ export default function transformer(
         call.value.arguments = [first, customEqualityFn];
         return;
       }
-
-      if (second.type === 'Identifier') {
-      }
     });
 
   /**