refactor(body): remove Incoming::channel helper

Author: tottoto

src/body/incoming.rs

@@ -100,15 +100,6 @@ const WANT_PENDING: usize = 1;
 const WANT_READY: usize = 2;
 
 impl Incoming {
-    /// Create a `Body` stream with an associated sender half.
-    ///
-    /// Useful when wanting to stream chunks from another thread.
-    #[inline]
-    #[cfg(test)]
-    pub(crate) fn channel() -> (Sender, Incoming) {
-        Self::new_channel(DecodedLength::CHUNKED, /*wanter =*/ false)
-    }
-
     #[cfg(all(feature = "http1", any(feature = "client", feature = "server")))]
     pub(crate) fn new_channel(content_length: DecodedLength, wanter: bool) -> (Sender, Incoming) {
         let (data_tx, data_rx) = mpsc::channel(0);
@@ -482,7 +473,11 @@ mod tests {
 
         eq(Incoming::empty(), SizeHint::with_exact(0), "empty");
 
-        eq(Incoming::channel().1, SizeHint::new(), "channel");
+        eq(
+            Incoming::new_channel(DecodedLength::CHUNKED, /*wanter =*/ false).1,
+            SizeHint::new(),
+            "channel",
+        );
 
         eq(
             Incoming::new_channel(DecodedLength::new(4), /*wanter =*/ false).1,
@@ -494,7 +489,7 @@ mod tests {
     #[cfg(not(miri))]
     #[tokio::test]
     async fn channel_abort() {
-        let (tx, mut rx) = Incoming::channel();
+        let (tx, mut rx) = Incoming::new_channel(DecodedLength::CHUNKED, /*wanter =*/ false);
 
         tx.abort();
 
@@ -505,7 +500,8 @@ mod tests {
     #[cfg(all(not(miri), feature = "http1"))]
     #[tokio::test]
     async fn channel_abort_when_buffer_is_full() {
-        let (mut tx, mut rx) = Incoming::channel();
+        let (mut tx, mut rx) =
+            Incoming::new_channel(DecodedLength::CHUNKED, /*wanter =*/ false);
 
         tx.try_send_data("chunk 1".into()).expect("send 1");
         // buffer is full, but can still send abort
@@ -527,7 +523,7 @@ mod tests {
     #[cfg(feature = "http1")]
     #[test]
     fn channel_buffers_one() {
-        let (mut tx, _rx) = Incoming::channel();
+        let (mut tx, _rx) = Incoming::new_channel(DecodedLength::CHUNKED, /*wanter =*/ false);
 
         tx.try_send_data("chunk 1".into()).expect("send 1");
 
@@ -539,7 +535,7 @@ mod tests {
     #[cfg(not(miri))]
     #[tokio::test]
     async fn channel_empty() {
-        let (_, mut rx) = Incoming::channel();
+        let (_, mut rx) = Incoming::new_channel(DecodedLength::CHUNKED, /*wanter =*/ false);
 
         assert!(rx.frame().await.is_none());
     }

src/proto/h1/dispatch.rs

@@ -764,7 +764,8 @@ mod tests {
         assert!(dispatcher.poll().is_pending());
 
         let body = {
-            let (mut tx, body) = IncomingBody::channel();
+            let (mut tx, body) =
+                IncomingBody::new_channel(DecodedLength::CHUNKED, /*wanter =*/ false);
             tx.try_send_data("".into()).unwrap();
             body
         };