Skip to content

Commit c7cead2

Browse files
committed
cleaned up the "seen" parameter in setResources after Micah's optimization made that unnecessary
1 parent 09edf0e commit c7cead2

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

src/data/model/immutable/HashedObject.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -290,15 +290,13 @@ abstract class HashedObject {
290290
return Hashing.forValue('#' + this.getId() + '.' + fieldName);
291291
}
292292

293-
setResources(resources: Resources, seen: Set<HashedObject> = new Set()): void {
293+
setResources(resources: Resources): void {
294294
if (this._resources === resources) return;
295-
if (seen?.has(this)) return;
296295

297296
this._resources = resources;
298-
seen.add(this)
299297

300298
for (const subobj of this.getDirectSubObjects().values()) {
301-
subobj.setResources(resources, seen);
299+
subobj.setResources(resources);
302300
}
303301
}
304302

src/data/model/mutable/MutableObject.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -655,10 +655,9 @@ abstract class MutableObject extends HashedObject {
655655
return this._acceptedMutationOpClasses;
656656
}
657657

658-
setResources(resources: Resources, seen = new Set<HashedObject>()): void {
659-
if (seen.has(this)) return;
660-
661-
seen.add(this);
658+
setResources(resources: Resources): void {
659+
660+
if (this.getResources() === resources) return;
662661

663662
let reBindToStore = false;
664663

@@ -675,7 +674,7 @@ abstract class MutableObject extends HashedObject {
675674

676675
for (const aliases of this.getMutableContents().values()) {
677676
for (const obj of aliases) {
678-
obj.setResources(resources, seen);
677+
obj.setResources(resources);
679678
}
680679
}
681680

0 commit comments

Comments
 (0)