better error handling for auth failures

Author: sbazerque

src/data/collections/causal/CausalArray.ts

@@ -15,7 +15,7 @@ import { ClassRegistry } from 'data/model/literals';
 import { MutableContentEvents } from 'data/model/mutable/MutableObject';
 import { MultiMap } from 'util/multimap';
 import { InvalidateAfterOp } from 'data/model/causal';
-import { BaseCausalCollection, CausalCollection, CausalCollectionConfig, CausalCollectionOp } from './CausalCollection';
+import { AuthError, BaseCausalCollection, CausalCollection, CausalCollectionConfig, CausalCollectionOp } from './CausalCollection';
 import { Identity } from 'data/identity';
 
 // A mutable list with a 
@@ -264,7 +264,7 @@ class CausalArray<T> extends BaseCausalCollection<T> implements CausalCollection
             this.setCurrentPrevOpsTo(insertOp);
 
             if (!(await auth.attempt(insertOp))) {
-                throw new Error('Cannot authorize insertion operation on CausalArray ' + this.hash() + ', author is: ' + author?.hash());
+                throw new AuthError('Cannot authorize insertion operation on CausalArray ' + this.hash() + ', author is: ' + author?.hash());
             }
 
             await this.applyNewOp(insertOp);
@@ -398,7 +398,7 @@ class CausalArray<T> extends BaseCausalCollection<T> implements CausalCollection
                 this.setCurrentPrevOpsTo(deleteOp);
 
                 if (!(await auth.attempt(deleteOp))) {
-                    throw new Error('Cannot authorize delete operation on CausalArray ' + this.hash() + ', author is: ' + author?.hash());
+                    throw new AuthError('Cannot authorize delete operation on CausalArray ' + this.hash() + ', author is: ' + author?.hash());
                 }
 
                 deleteOps.push(deleteOp);

src/data/collections/causal/CausalCollection.ts

@@ -4,6 +4,10 @@ import { Hash} from '../../model/hashing'
 import { Authorization, Authorizer } from 'data/model';
 import { BaseCollection, CollectionConfig } from '../mutable/Collection';
 
+class AuthError extends Error {
+
+};
+
 interface CausalCollection<T> {
     has(elmt: T): boolean;
     hasByHash(hash: Hash): boolean;
@@ -92,5 +96,5 @@ abstract class CausalCollectionOp extends MutationOp {
     }
 }
 
-export { CausalCollection, BaseCausalCollection, CausalCollectionOp };
+export { CausalCollection, BaseCausalCollection, CausalCollectionOp, AuthError };
 export type { CausalCollectionConfig };

src/data/collections/causal/CausalSet.ts

@@ -8,7 +8,7 @@ import { Authorization, Verification } from '../../model/causal/Authorization';
 import { HashedSet } from '../../model/immutable/HashedSet';
 import { MutableSetEvents } from '../../collections/mutable/MutableSet';
 import { MutableContentEvents } from '../../model/mutable/MutableObject';
-import { BaseCausalCollection, CausalCollection, CausalCollectionConfig, CausalCollectionOp } from './CausalCollection';
+import { AuthError, BaseCausalCollection, CausalCollection, CausalCollectionConfig, CausalCollectionOp } from './CausalCollection';
 import { ClassRegistry } from 'data/model/literals';
 
 /*
@@ -234,7 +234,7 @@ class CausalSet<T> extends BaseCausalCollection<T> implements CausalCollection<T
         this.setCurrentPrevOpsTo(addOp);
 
         if (!(await auth.attempt(addOp))) {
-            throw new Error('Cannot authorize addition operation on CausalSet ' + this.hash() + ', author is: ' + author?.hash());
+            throw new AuthError('Cannot authorize addition operation on CausalSet ' + this.hash() + ', author is: ' + author?.hash());;
         }
 
         return this.applyNewOp(addOp).then(() => true);
@@ -268,7 +268,7 @@ class CausalSet<T> extends BaseCausalCollection<T> implements CausalCollection<T
             this.setCurrentPrevOpsTo(deleteOp);
 
             if (!(await auth.attempt(deleteOp))) {
-                throw new Error('Cannot authorize delete operation on CausalSet ' + this.hash() + ', author is: ' + author?.hash());
+                throw new AuthError('Cannot authorize delete operation on CausalSet ' + this.hash() + ', author is: ' + author?.hash());
             }
 
             deleteOps.push(deleteOp);

test/data/types/FeatureSet.ts

@@ -1,4 +1,5 @@
 import { CausalSet, SingleAuthorCausalSet, CausalSetAddOp, CausalSetDeleteOp } from 'data/collections';
+import { AuthError } from 'data/collections/causal/CausalCollection';
 import { Identity } from 'data/identity';
 import { Hash, HashedObject, MutationOp } from 'data/model';
 import { Authorizer, Authorization } from 'data/model';
@@ -40,7 +41,12 @@ class FeatureSet extends CausalSet<Feature> {
         try {            
             return await super.add(feature, author, auth);
         } catch (e) {
-            return false;
+            if (e instanceof AuthError) {
+                return false;
+            } else {
+                throw e;
+            }
+            
         }
     }
 
@@ -55,7 +61,12 @@ class FeatureSet extends CausalSet<Feature> {
         try {
             return await super.delete(feature, author, auth);
         } catch (e) {
-            return false;
+            if (e instanceof AuthError) {
+                return false;
+            } else {
+                throw e;
+            }
+            
         }
     }
 
@@ -64,9 +75,13 @@ class FeatureSet extends CausalSet<Feature> {
         const auth = this.createAuthorizerFor(author);
 
         try {
-            return super.deleteByHash(hash, author, auth);
+            return await super.deleteByHash(hash, author, auth);
         } catch (e) {
-            return false;
+            if (e instanceof AuthError) {
+                return false;
+            } else {
+                throw e;
+            }   
         }
 
     }