setup cloexec flag for stdioevfd in tty case

gao-feng · gao-feng · commit a526923e3e71 · 2017-01-19T18:23:12.000+08:00
otherwise these fds will be seen by other execs and new containers

Signed-off-by: Gao feng &lt;omarapazanadi@gmail.com&gt;
diff --git a/src/exec.c b/src/exec.c
@@ -444,9 +444,12 @@ static int hyper_setup_stdio_events(struct hyper_exec *exec, struct stdio_config
 {
 	if (exec->tty) {
 		io->stdinevfd = dup(exec->ptyfd);
+		hyper_setfd_cloexec(io->stdinevfd);
 		io->stdoutevfd = dup(exec->ptyfd);
+		hyper_setfd_cloexec(io->stdoutevfd);
 		if (exec->errseq == 0) {
 			io->stderrevfd = dup(exec->ptyfd);
+			hyper_setfd_cloexec(io->stderrevfd);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -444,9 +444,12 @@ static int hyper_setup_stdio_events(struct hyper_exec *exec, struct stdio_config`
`444`	`444`	`{`
`445`	`445`	`if (exec->tty) {`
`446`	`446`	`io->stdinevfd = dup(exec->ptyfd);`
	`447`	`+ hyper_setfd_cloexec(io->stdinevfd);`
`447`	`448`	`io->stdoutevfd = dup(exec->ptyfd);`
	`449`	`+ hyper_setfd_cloexec(io->stdoutevfd);`
`448`	`450`	`if (exec->errseq == 0) {`
`449`	`451`	`io->stderrevfd = dup(exec->ptyfd);`
	`452`	`+ hyper_setfd_cloexec(io->stderrevfd);`
`450`	`453`	`}`
`451`	`454`	`}`
`452`	`455`