Skip to content

Commit 3fb5ef7

Browse files
fix prop warnings (#1366)
Very minor PR which fixes 2 HTML structure issues (div under p, button under button). Before: <img width="968" height="146" alt="Screenshot 2025-11-13 at 6 58 22 PM" src="https://github.com/user-attachments/assets/ca16ea04-d308-47ec-a3f0-74a8c639dd4b" /> After: Non prop errors (on search page at least)
1 parent 94a669d commit 3fb5ef7

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

.changeset/chatty-parents-drum.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@hyperdx/app": patch
3+
---
4+
5+
Small fix for html structure nesting issues

packages/app/src/components/DBTable/DBRowTableIconButton.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,10 @@ export const DBRowTableIconButton: React.FC<DBRowTableIconButtonProps> = ({
5151
>
5252
<UnstyledButton
5353
onClick={handleClick}
54+
component="div"
5455
className={baseClasses}
5556
tabIndex={tabIndex}
57+
role="button"
5658
>
5759
{isActive ? <IconCheck size={iconSize} /> : children}
5860
</UnstyledButton>

packages/app/src/components/SQLInlineEditor.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,7 @@ export default function SQLInlineEditor({
327327
style={{
328328
whiteSpace: 'nowrap',
329329
}}
330+
component="div"
330331
>
331332
<Tooltip label={tooltipText} disabled={!tooltipText}>
332333
<Flex align="center" gap={2}>

packages/app/tests/e2e/features/shared/multiline.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ test.describe('Multiline Input', { tag: '@search' }, () => {
110110
if (config.mode === 'SQL') {
111111
const scopedContainer = formSelector ? container : page;
112112
const whereLabel = scopedContainer.locator(
113-
`p.mantine-Text-root:has-text("${whereText}")`,
113+
`div.mantine-Text-root:has-text("${whereText}")`,
114114
);
115115
await expect(whereLabel).toBeVisible();
116116
}
@@ -122,7 +122,7 @@ test.describe('Multiline Input', { tag: '@search' }, () => {
122122
? (() => {
123123
const scopedContainer = formSelector ? container : page;
124124
const whereContainer = scopedContainer.locator(
125-
`div:has(p.mantine-Text-root:has-text("${whereText}"))`,
125+
`div:has(div.mantine-Text-root:has-text("${whereText}"))`,
126126
);
127127
return whereContainer.locator('.cm-editor').first();
128128
})()

0 commit comments

Comments
 (0)