fix: console log uncaught exceptions (#159)

sdk should stdout the exception before exit

Author: wrn14897

.changeset/khaki-melons-mix.md

@@ -0,0 +1,6 @@
+---
+'@hyperdx/instrumentation-exception': patch
+'@hyperdx/node-opentelemetry': patch
+---
+
+fix: console log uncaught exceptions

packages/instrumentation-exception/src/node/utils/errorhandling.ts

@@ -1,3 +1,4 @@
+import { consoleSandbox } from '@sentry/utils';
 import { diag } from '@opentelemetry/api';
 
 const DEFAULT_SHUTDOWN_TIMEOUT = 2000;
@@ -21,7 +22,10 @@ export async function logAndExitProcess(
   error: Error,
   forceFlush: () => Promise<void>,
 ): Promise<void> {
-  diag.error('Exiting process due to fatal error', error);
+  consoleSandbox(() => {
+    // eslint-disable-next-line no-console
+    console.error(error);
+  });
 
   try {
     await Promise.race([

packages/node-opentelemetry/examples/dummy_hardcrash.js

@@ -0,0 +1,39 @@
+const express = require('express');
+const HyperDX = require('../build/src');
+
+HyperDX.init({
+  apiKey: '',
+  service: 'hard-crash',
+});
+
+// Crash immediately
+har();
+
+// unhandledRejection
+// new Promise((resolve, reject) => {
+//   reject(new Error('🦄🦄🦄🦄'));
+// });
+
+const PORT = parseInt(process.env.PORT || '7788');
+const app = express();
+
+app.get('/uncaught', async (req, res) => {
+  setTimeout(() => {
+    throw new Error('💥💥💥💥');
+  }, 2000);
+  res.send('Uncaught exception in 2 seconds');
+});
+
+app.get('/crash', (req, res) => {
+  throw new Error('🧨🧨🧨🧨');
+});
+
+app.get('/', (req, res) => {
+  res.send('Hello World!');
+});
+
+// HyperDX.setupExpressErrorHandler(app);
+
+app.listen(PORT, () => {
+  console.log(`Listening for requests on http://localhost:${PORT}`);
+});

packages/node-opentelemetry/examples/dummy_redis4.js

@@ -0,0 +1,35 @@
+const express = require('express');
+const Redis = require('redis');
+const HyperDX = require('../build/src');
+
+HyperDX.init({
+  apiKey: '',
+  service: 'dummy_redis4',
+});
+
+const PORT = parseInt(process.env.PORT || '7788');
+const app = express();
+
+app.use(express.json());
+app.get('/', async (req, res) => {
+  const client = await Redis.createClient({
+    host: 'localhost',
+    port: 6379,
+  }).connect();
+  // await redis.commandsExecutor('set', 'foo', 'bar');
+  await client.set('foo1', 'bar1');
+  await client.get('foo1');
+  // await redis.sendCommand(['SET', 'foo1', 'bar1']);
+  // await redis.sendCommand(['GET', 'foo1']);
+  // const [setKeyReply, otherKeyValue] = await client
+  //   .multi()
+  //   .set('key', 'value')
+  //   .get('another-key')
+  //   .exec(); // ['OK', 'another-value']
+  await client.disconnect();
+  res.send('Hello World!!!');
+});
+
+app.listen(PORT, () => {
+  console.log(`Listening for requests on http://localhost:${PORT}`);
+});