test: parseLogAttributes

Author: wrn14897

packages/node-opentelemetry/examples/dummy.js

@@ -305,6 +305,16 @@ app.get('/logs', async (req, res) => {
     headers: req.headers,
     method: req.method,
     url: req.url,
+    nested: [
+      {
+        foo: 'bar',
+      },
+    ],
+    nested2: {
+      nested3: {
+        foo: 'bar',
+      },
+    },
   });
   pinoLogger.info('Pino 🍕');
 

packages/node-opentelemetry/src/otel-logger/__tests__/__snapshots__/index.test.ts.snap

@@ -13,3 +13,24 @@ exports[`otel-logger getSeverityNumber 1`] = `
   "warning": 13,
 }
 `;
+
+exports[`otel-logger parseLogAttributes 1`] = `
+{
+  "a": 1,
+  "b": "2",
+  "c": "[{"d":3}]",
+  "e": [
+    1,
+    2,
+    3,
+  ],
+  "f": [
+    "a",
+    "b",
+    "c",
+  ],
+  "g": {
+    "h": "i",
+  },
+}
+`;

packages/node-opentelemetry/src/otel-logger/__tests__/index.test.ts

@@ -1,4 +1,4 @@
-import { getSeverityNumber } from '..';
+import { getSeverityNumber, parseLogAttributes } from '..';
 
 describe('otel-logger', () => {
   it('getSeverityNumber', () => {
@@ -14,4 +14,19 @@ describe('otel-logger', () => {
       warning: getSeverityNumber('warning'),
     }).toMatchSnapshot();
   });
+
+  it('parseLogAttributes', () => {
+    expect(
+      parseLogAttributes({
+        a: 1,
+        b: '2',
+        c: [{ d: 3 }],
+        e: [1, 2, 3],
+        f: ['a', 'b', 'c'],
+        g: {
+          h: 'i',
+        },
+      }),
+    ).toMatchSnapshot();
+  });
 });

packages/node-opentelemetry/src/otel-logger/index.ts

@@ -101,7 +101,9 @@ export const parseLogAttributes = (
           if (isPlainObject(firstItem)) {
             attributes[key] = jsonToString(value);
           }
-        } else {
+        }
+
+        if (attributes[key] === undefined) {
           attributes[key] = value;
         }
       }