Skip to content

Conversation

@arnavk23
Copy link

@arnavk23 arnavk23 commented Nov 15, 2025

  • Adds an integration for tuning sktime detector / anomaly-detection estimators from Hyperactive.
  • Provides an experiment adapter SktimeDetectorExperiment and a wrapper estimator TSDetectorOptCv so Hyperactive optimizers can tune sktime detectors with the same workflow used for classifiers/forecasters.
  • Fixes [ENH] sktime detectors integration #197

@arnavk23
Copy link
Author

@fkiraly @SimonBlanke please review this pr. Thanks!

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks nice, but it feels like your are trying to import an evaluate function which does not exist, from sktime.

Currently there is no evaluate for detectors in sktime, so you may have to write it first there! Metrics and estimator API already exists, and imo it should be similar to forecasting. I would suggest you open an issue in sktime to add the evaluate method for detectors if it dtoes not exist, and add the routine there.

@arnavk23 arnavk23 requested a review from fkiraly November 17, 2025 00:06
@fkiraly
Copy link
Collaborator

fkiraly commented Nov 24, 2025

@arnavk23, can you describe how this is integrated with sktime, and whether a PR in sktime needs to be merged first?

@arnavk23
Copy link
Author

@arnavk23, can you describe how this is integrated with sktime, and whether a PR in sktime needs to be merged first?

The mentioned PR in this pull request needs to merged first in sktime.

@fkiraly
Copy link
Collaborator

fkiraly commented Nov 28, 2025

code quality checks are failing - please use pre-commit to fix the formatting issues

@arnavk23
Copy link
Author

code quality checks are failing - please use pre-commit to fix the formatting issues

Made the changes. Please see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] sktime detectors integration

2 participants